fix: render script command hints with active agent separator#2649
Open
PascalThuet wants to merge 2 commits into
Open
fix: render script command hints with active agent separator#2649PascalThuet wants to merge 2 commits into
PascalThuet wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Bash and PowerShell helper scripts to format user-facing “Run /speckit…” hints using the configured invoke_separator from .specify/integration.json, and adds tests to validate the updated messaging.
Changes:
- Add shared helpers to compute the invoke separator and format
/speckit{separator}{command}consistently (Bash + PowerShell). - Update setup/check scripts to use the formatted command in error/help hints.
- Extend integration tests to cover separator-aware messaging for both Bash and PowerShell.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_setup_tasks.py | Adds helper to write integration.json and new assertions for separator-aware hint strings. |
| scripts/powershell/setup-tasks.ps1 | Uses Format-SpecKitCommand to generate plan/specify hint commands dynamically. |
| scripts/powershell/common.ps1 | Adds Get-InvokeSeparator + Format-SpecKitCommand helpers. |
| scripts/powershell/check-prerequisites.ps1 | Uses Format-SpecKitCommand for specify/plan/tasks hints. |
| scripts/bash/setup-tasks.sh | Uses format_speckit_command for plan/specify hints. |
| scripts/bash/common.sh | Adds get_invoke_separator + format_speckit_command helpers. |
| scripts/bash/check-prerequisites.sh | Uses format_speckit_command for specify/plan/tasks hints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5df378d to
6cfa652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invoke_separator.setup-tasksandcheck-prerequisites.Why
Shared scripts were hardcoding dotted slash commands such as
/speckit.plan,/speckit.specify, and/speckit.tasks.That is correct for internal command IDs and dot-based integrations, but it is confusing for agents whose installed commands use
invoke_separator: "-", where the resolvable slash command is/speckit-plan.Implementation
The shared script helpers now read
.specify/integration.json, resolve the default integration's storedinvoke_separator, and format the displayed slash command accordingly. If state is missing or malformed, they fall back to the dotted form.Validation
git diff --checkbash -n scripts/bash/common.shbash -n scripts/bash/setup-tasks.shbash -n scripts/bash/check-prerequisites.shuv run pytest tests/test_setup_tasks.py -vuv run pytest tests/test_timestamp_branches.py -vPowerShell was not available in the local environment, so the PowerShell regression tests were collected but skipped.