Skip to content

Commit 030488a

Browse files
Make local and remote query results match
In the previous commit we're now displaying number of results for remote queries. Previously we could only do this for local queries. Let's make the format match for both types of queries by displaying number of results in parentheses: `(x results)`. Co-authored-by: Shati Patel <shati-patel@github.com>
1 parent 377f796 commit 030488a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

extensions/ql-vscode/src/history-item-label-provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export class HistoryItemLabelProvider {
5757
t: item.startTime,
5858
q: item.getQueryName(),
5959
d: item.initialInfo.databaseInfo.name,
60-
r: `${resultCount} results`,
60+
r: `(${resultCount} results)`,
6161
s: statusString,
6262
f: item.getQueryFileName(),
6363
'%': '%',

extensions/ql-vscode/src/vscode-tests/no-workspace/history-item-label-provider.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ describe('HistoryItemLabelProvider', () => {
2727
expect(labelProvider.getLabel(fqi)).to.eq('xxx');
2828

2929
fqi.userSpecifiedLabel = '%t %q %d %s %f %r %%';
30-
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql 456 results %`);
30+
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql (456 results) %`);
3131

3232
fqi.userSpecifiedLabel = '%t %q %d %s %f %r %%::%t %q %d %s %f %r %%';
33-
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql 456 results %::${dateStr} query-name db-name in progress query-file.ql 456 results %`);
33+
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql (456 results) %::${dateStr} query-name db-name in progress query-file.ql (456 results) %`);
3434
});
3535

3636
it('should interpolate query when not user specified', () => {
@@ -40,10 +40,10 @@ describe('HistoryItemLabelProvider', () => {
4040

4141

4242
config.format = '%t %q %d %s %f %r %%';
43-
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql 456 results %`);
43+
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql (456 results) %`);
4444

4545
config.format = '%t %q %d %s %f %r %%::%t %q %d %s %f %r %%';
46-
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql 456 results %::${dateStr} query-name db-name in progress query-file.ql 456 results %`);
46+
expect(labelProvider.getLabel(fqi)).to.eq(`${dateStr} query-name db-name in progress query-file.ql (456 results) %::${dateStr} query-name db-name in progress query-file.ql (456 results) %`);
4747
});
4848

4949
it('should get query short label', () => {

0 commit comments

Comments
 (0)