Skip to content

Commit 159d900

Browse files
authored
Add start time to VariantAnalysis type (#1587)
1 parent 8c324a3 commit 159d900

File tree

7 files changed

+10
-2
lines changed

7 files changed

+10
-2
lines changed

extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export interface VariantAnalysis {
1414
repositoryLists?: string[],
1515
repositoryOwners?: string[],
1616
},
17+
executionStartTime: number;
1718
status: VariantAnalysisStatus,
1819
actionsWorkflowRunId?: number,
1920
failureReason?: VariantAnalysisFailureReason,

extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
184184
filePath: `variant_analysis_${variantAnalysisId}.ql`,
185185
language: variantAnalysisResponse.query_language as VariantAnalysisQueryLanguage,
186186
},
187-
databases: {}
187+
databases: {},
188+
executionStartTime: 0,
188189
}, variantAnalysisResponse);
189190

190191
void commands.executeCommand('codeQL.openVariantAnalysisView', processedVariantAnalysis.id);

extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@ export function processVariantAnalysis(
3030
language: submission.query.language
3131
},
3232
databases: submission.databases,
33+
executionStartTime: submission.startTime
3334
}, response);
3435
}
3536

3637
export function processUpdatedVariantAnalysis(
37-
previousVariantAnalysis: Pick<VariantAnalysis, 'query' | 'databases'>,
38+
previousVariantAnalysis: Pick<VariantAnalysis, 'query' | 'databases' | 'executionStartTime'>,
3839
response: ApiVariantAnalysis
3940
): VariantAnalysis {
4041
let scannedRepos: VariantAnalysisScannedRepository[] = [];
@@ -57,6 +58,7 @@ export function processUpdatedVariantAnalysis(
5758
language: previousVariantAnalysis.query.language
5859
},
5960
databases: previousVariantAnalysis.databases,
61+
executionStartTime: previousVariantAnalysis.executionStartTime,
6062
status: processApiStatus(response.status),
6163
actionsWorkflowRunId: response.actions_workflow_run_id,
6264
scannedRepos: scannedRepos,

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisAnalyzedRepos.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe(VariantAnalysisAnalyzedRepos.name, () => {
1919
language: VariantAnalysisQueryLanguage.Javascript,
2020
},
2121
databases: {},
22+
executionStartTime: 1611234567890,
2223
status: VariantAnalysisStatus.InProgress,
2324
scannedRepos: [
2425
{

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisOutcomePanels.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ describe(VariantAnalysisOutcomePanels.name, () => {
1818
language: VariantAnalysisQueryLanguage.Javascript,
1919
},
2020
databases: {},
21+
executionStartTime: 1611234567890,
2122
status: VariantAnalysisStatus.InProgress,
2223
scannedRepos: [
2324
{

extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-processor.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ describe('Variant Analysis processor', function() {
3535
'databases': {
3636
'repositories': ['1', '2', '3'],
3737
},
38+
'executionStartTime': mockSubmission.startTime,
3839
'status': 'succeeded',
3940
'actionsWorkflowRunId': mockApiResponse.actions_workflow_run_id,
4041
'scannedRepos': [

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export function createMockVariantAnalysis(
2525
databases: {
2626
repositories: ['1', '2', '3'],
2727
},
28+
executionStartTime: faker.datatype.number(),
2829
status: status,
2930
actionsWorkflowRunId: faker.datatype.number(),
3031
scannedRepos: scannedRepos,

0 commit comments

Comments
 (0)