Merge pull request #1698 from github/robertbrignull/await_monitor

robertbrignull · web-flow · commit 30dd16326589 · 2022-11-02T12:00:57.000Z
Don't await the monitoring command
diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts
@@ -64,7 +64,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
     } else {
       await this.setVariantAnalysis(variantAnalysis);
       if (!await isVariantAnalysisComplete(variantAnalysis, this.makeResultDownloadChecker(variantAnalysis))) {
-        await commands.executeCommand('codeQL.monitorVariantAnalysis', variantAnalysis);
+        void commands.executeCommand('codeQL.monitorVariantAnalysis', variantAnalysis);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA`
`64`	`64`	`} else {`
`65`	`65`	`await this.setVariantAnalysis(variantAnalysis);`
`66`	`66`	`if (!await isVariantAnalysisComplete(variantAnalysis, this.makeResultDownloadChecker(variantAnalysis))) {`
`67`		`- await commands.executeCommand('codeQL.monitorVariantAnalysis', variantAnalysis);`
	`67`	`+ void commands.executeCommand('codeQL.monitorVariantAnalysis', variantAnalysis);`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`	`}`