Merge pull request #1701 from github/koesie10/rename-not-found-repo-nwos

koesie10 · web-flow · commit 3c860cfcff55 · 2022-11-02T13:18:02.000+01:00
Rename `not_found_repo_nwos` to `not_found_repos`
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/13-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/13-getVariantAnalysis.json
@@ -756,7 +756,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/14-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/14-getVariantAnalysis.json
@@ -756,7 +756,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/15-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/15-getVariantAnalysis.json
@@ -756,7 +756,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/16-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/16-getVariantAnalysis.json
@@ -756,7 +756,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/17-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/17-getVariantAnalysis.json
@@ -756,7 +756,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/18-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/18-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/19-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/19-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/2-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/2-getVariantAnalysis.json
@@ -752,7 +752,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/20-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/20-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/21-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/21-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/22-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/22-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/23-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/23-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/26-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/26-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/27-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/27-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/28-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/28-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/29-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/29-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/3-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/3-getVariantAnalysis.json
@@ -752,7 +752,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/30-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/30-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/31-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/31-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/32-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/32-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/33-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/33-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/34-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/34-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/36-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/36-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/38-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/38-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/39-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/39-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/4-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/4-getVariantAnalysis.json
@@ -752,7 +752,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/40-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/40-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/41-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/41-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/42-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/42-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/43-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/43-getVariantAnalysis.json
@@ -760,7 +760,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/44-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/44-getVariantAnalysis.json
@@ -762,7 +762,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/47-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/47-getVariantAnalysis.json
@@ -762,7 +762,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/48-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/48-getVariantAnalysis.json
@@ -762,7 +762,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/49-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/49-getVariantAnalysis.json
@@ -762,7 +762,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/5-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/5-getVariantAnalysis.json
@@ -752,7 +752,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/50-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/50-getVariantAnalysis.json
@@ -762,7 +762,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/51-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/51-getVariantAnalysis.json
@@ -763,7 +763,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/6-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/6-getVariantAnalysis.json
@@ -752,7 +752,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/7-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/7-getVariantAnalysis.json
@@ -752,7 +752,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/8-getVariantAnalysis.json b/extensions/ql-vscode/src/mocks/scenarios/problem-query-warnings/8-getVariantAnalysis.json
@@ -756,7 +756,7 @@
             }
           ]
         },
-        "not_found_repo_nwos": {
+        "not_found_repos": {
           "repository_count": 110,
           "repository_full_names": [
             "evanw/node-source-map-support",
diff --git a/extensions/ql-vscode/src/remote-queries/gh-api/variant-analysis.ts b/extensions/ql-vscode/src/remote-queries/gh-api/variant-analysis.ts
@@ -79,7 +79,7 @@ export interface VariantAnalysisRepoTask {
 
 export interface VariantAnalysisSkippedRepositories {
   access_mismatch_repos?: VariantAnalysisSkippedRepositoryGroup,
-  not_found_repo_nwos?: VariantAnalysisNotFoundRepositoryGroup,
+  not_found_repos?: VariantAnalysisNotFoundRepositoryGroup,
   no_codeql_db_repos?: VariantAnalysisSkippedRepositoryGroup,
   over_limit_repos?: VariantAnalysisSkippedRepositoryGroup
 }
diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts
@@ -100,7 +100,7 @@ function processSkippedRepositories(
 
   return {
     accessMismatchRepos: processRepoGroup(skippedRepos.access_mismatch_repos),
-    notFoundRepos: processNotFoundRepoGroup(skippedRepos.not_found_repo_nwos),
+    notFoundRepos: processNotFoundRepoGroup(skippedRepos.not_found_repos),
     noCodeqlDbRepos: processRepoGroup(skippedRepos.no_codeql_db_repos),
     overLimitRepos: processRepoGroup(skippedRepos.over_limit_repos)
   };
diff --git a/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-processor.test.ts b/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-processor.test.ts
diff --git a/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/gh-api/skipped-repositories.ts b/extensions/ql-vscode/src/vscode-tests/factories/remote-queries/gh-api/skipped-repositories.ts

Original file line number	Diff line number	Diff line change
`@@ -756,7 +756,7 @@`
`756`	`756`	`}`
`757`	`757`	`]`
`758`	`758`	`},`
`759`		`- "not_found_repo_nwos": {`
	`759`	`+ "not_found_repos": {`
`760`	`760`	`"repository_count": 110,`
`761`	`761`	`"repository_full_names": [`
`762`	`762`	`"evanw/node-source-map-support",`
Original file line number	Diff line number	Diff line change
`@@ -760,7 +760,7 @@`
`760`	`760`	`}`
`761`	`761`	`]`
`762`	`762`	`},`
`763`		`- "not_found_repo_nwos": {`
	`763`	`+ "not_found_repos": {`
`764`	`764`	`"repository_count": 110,`
`765`	`765`	`"repository_full_names": [`
`766`	`766`	`"evanw/node-source-map-support",`
Original file line number	Diff line number	Diff line change
`@@ -752,7 +752,7 @@`
`752`	`752`	`}`
`753`	`753`	`]`
`754`	`754`	`},`
`755`		`- "not_found_repo_nwos": {`
	`755`	`+ "not_found_repos": {`
`756`	`756`	`"repository_count": 110,`
`757`	`757`	`"repository_full_names": [`
`758`	`758`	`"evanw/node-source-map-support",`