Merge pull request #1685 from github/koesie10/open-live-results-on-github

Add opening on GitHub of live results variant analyses

Author: koesie10

extensions/ql-vscode/src/query-history-info.ts

@@ -71,3 +71,15 @@ export function buildRepoLabel(item: RemoteQueryHistoryItem | VariantAnalysisHis
     assertNever(item);
   }
 }
+
+export function getActionsWorkflowRunUrl(item: RemoteQueryHistoryItem | VariantAnalysisHistoryItem): string {
+  if (item.t === 'remote') {
+    const { actionsWorkflowRunId: workflowRunId, controllerRepository: { owner, name } } = item.remoteQuery;
+    return `https://github.com/${owner}/${name}/actions/runs/${workflowRunId}`;
+  } else if (item.t === 'variant-analysis') {
+    const { actionsWorkflowRunId, controllerRepo: { fullName } } = item.variantAnalysis;
+    return `https://github.com/${fullName}/actions/runs/${actionsWorkflowRunId}`;
+  } else {
+    assertNever(item);
+  }
+}

extensions/ql-vscode/src/query-history.ts

@@ -31,7 +31,7 @@ import { commandRunner } from './commandRunner';
 import { ONE_HOUR_IN_MS, TWO_HOURS_IN_MS } from './pure/time';
 import { assertNever, getErrorMessage, getErrorStack } from './pure/helpers-pure';
 import { CompletedLocalQueryInfo, LocalQueryInfo } from './query-results';
-import { getQueryId, getQueryText, QueryHistoryInfo } from './query-history-info';
+import { getActionsWorkflowRunUrl, getQueryId, getQueryText, QueryHistoryInfo } from './query-history-info';
 import { DatabaseManager } from './databases';
 import { registerQueryHistoryScrubber } from './query-history-scrubber';
 import { QueryStatus, variantAnalysisStatusToQueryStatus } from './query-status';
@@ -1213,17 +1213,17 @@ export class QueryHistoryManager extends DisposableObject {
   ) {
     const { finalSingleItem, finalMultiSelect } = this.determineSelection(singleItem, multiSelect);
 
-    // Remote queries only
-    if (!this.assertSingleQuery(finalMultiSelect) || !finalSingleItem || finalSingleItem.t !== 'remote') {
+    if (!this.assertSingleQuery(finalMultiSelect) || !finalSingleItem) {
+      return;
+    }
+
+    if (finalSingleItem.t === 'local') {
       return;
     }
 
-    const { actionsWorkflowRunId: workflowRunId, controllerRepository: { owner, name } } = finalSingleItem.remoteQuery;
+    const actionsWorkflowRunUrl = getActionsWorkflowRunUrl(finalSingleItem);
 
-    await commands.executeCommand(
-      'vscode.open',
-      Uri.parse(`https://github.com/${owner}/${name}/actions/runs/${workflowRunId}`)
-    );
+    await commands.executeCommand('vscode.open', Uri.parse(actionsWorkflowRunUrl));
   }
 
   async handleCopyRepoList(

extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts

@@ -3,7 +3,7 @@ import { AnalysisAlert, AnalysisRawResults } from './analysis-result';
 
 export interface VariantAnalysis {
   id: number,
-  controllerRepoId: number,
+  controllerRepo: Repository;
   query: {
     name: string,
     filePath: string,

extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts

@@ -51,7 +51,7 @@ export class VariantAnalysisMonitor extends DisposableObject {
 
       variantAnalysisSummary = await ghApiClient.getVariantAnalysis(
         credentials,
-        variantAnalysis.controllerRepoId,
+        variantAnalysis.controllerRepo.id,
         variantAnalysis.id
       );
 

extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts

@@ -52,7 +52,11 @@ export function processUpdatedVariantAnalysis(
 
   const variantAnalysis: VariantAnalysis = {
     id: response.id,
-    controllerRepoId: response.controller_repo.id,
+    controllerRepo: {
+      id: response.controller_repo.id,
+      fullName: response.controller_repo.full_name,
+      private: response.controller_repo.private,
+    },
     query: previousVariantAnalysis.query,
     databases: previousVariantAnalysis.databases,
     executionStartTime: previousVariantAnalysis.executionStartTime,

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysis.stories.tsx

@@ -24,7 +24,11 @@ const Template: ComponentStory<typeof VariantAnalysisComponent> = (args) => (
 
 const variantAnalysis: VariantAnalysisDomainModel = {
   id: 1,
-  controllerRepoId: 1,
+  controllerRepo: {
+    id: 1,
+    fullName: 'octodemo/variant-analysis-controller',
+    private: false,
+  },
   actionsWorkflowRunId: 789263,
   query: {
     name: 'Example query',

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisAnalyzedRepos.stories.tsx

@@ -37,7 +37,11 @@ export const Example = Template.bind({});
 Example.args = {
   variantAnalysis: {
     id: 1,
-    controllerRepoId: 1,
+    controllerRepo: {
+      id: 1,
+      fullName: 'octodemo/variant-analysis-controller',
+      private: false,
+    },
     query: {
       name: 'Query name',
       filePath: 'example.ql',

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisHeader.stories.tsx

@@ -68,7 +68,11 @@ const Template: ComponentStory<typeof VariantAnalysisHeader> = (args) => (
 
 const buildVariantAnalysis = (data: Partial<VariantAnalysis>) => ({
   id: 1,
-  controllerRepoId: 1,
+  controllerRepo: {
+    id: 1,
+    fullName: 'octodemo/variant-analysis-controller',
+    private: false,
+  },
   query: {
     name: 'Query name',
     filePath: 'example.ql',

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisOutcomePanels.stories.tsx

@@ -30,7 +30,11 @@ const Template: ComponentStory<typeof VariantAnalysisOutcomePanels> = (args) =>
 
 const buildVariantAnalysis = (data: Partial<VariantAnalysis>) => ({
   id: 1,
-  controllerRepoId: 1,
+  controllerRepo: {
+    id: 1,
+    fullName: 'octodemo/variant-analysis-controller',
+    private: false,
+  },
   query: {
     name: 'Query name',
     filePath: 'example.ql',

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisAnalyzedRepos.spec.tsx

@@ -11,7 +11,11 @@ import { VariantAnalysisAnalyzedRepos, VariantAnalysisAnalyzedReposProps } from
 describe(VariantAnalysisAnalyzedRepos.name, () => {
   const defaultVariantAnalysis = {
     id: 1,
-    controllerRepoId: 1,
+    controllerRepo: {
+      id: 1,
+      fullName: 'octodemo/variant-analysis-controller',
+      private: false,
+    },
     actionsWorkflowRunId: 789263,
     query: {
       name: 'Example query',