Skip to content

Commit 45efca9

Browse files
authored
Merge pull request #1503 from github/koesie10/remove-open-on-github-for-mrva
Remove open on GitHub item from cancelled local results
2 parents 9071f54 + 7502fde commit 45efca9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

extensions/ql-vscode/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@
747747
{
748748
"command": "codeQLQueryHistory.removeHistoryItem",
749749
"group": "9_qlCommands",
750-
"when": "viewItem == interpretedResultsItem || viewItem == rawResultsItem || viewItem == remoteResultsItem || viewItem == cancelledResultsItem"
750+
"when": "viewItem == interpretedResultsItem || viewItem == rawResultsItem || viewItem == remoteResultsItem || viewItem == cancelledResultsItem || viewItem == cancelledRemoteResultsItem"
751751
},
752752
{
753753
"command": "codeQLQueryHistory.setLabel",
@@ -822,7 +822,7 @@
822822
{
823823
"command": "codeQLQueryHistory.openOnGithub",
824824
"group": "9_qlCommands",
825-
"when": "viewItem == remoteResultsItem || viewItem == inProgressRemoteResultsItem || viewItem == cancelledResultsItem"
825+
"when": "viewItem == remoteResultsItem || viewItem == inProgressRemoteResultsItem || viewItem == cancelledRemoteResultsItem"
826826
},
827827
{
828828
"command": "codeQLQueryHistory.copyRepoList",

extensions/ql-vscode/src/query-history.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ export class HistoryTreeDataProvider extends DisposableObject implements TreeDat
189189
break;
190190
case QueryStatus.Failed:
191191
treeItem.iconPath = this.failedIconPath;
192-
treeItem.contextValue = 'cancelledResultsItem';
192+
treeItem.contextValue = element.t === 'local' ? 'cancelledResultsItem' : 'cancelledRemoteResultsItem';
193193
break;
194194
default:
195195
assertNever(element.status);

0 commit comments

Comments
 (0)