Skip to content

Commit 53c404b

Browse files
committed
Add new date fields from API to variant analysis types
This will add some new date fields that have been added in the API to the variant analysis types and factories. They are stored as strings since storing them as `Date` would make the types inconsistent if they are serialized to JSON (`JSON.stringify` -> `JSON.parse` would result in strings rather than dates).
1 parent f8d5fd8 commit 53c404b

File tree

7 files changed

+17
-0
lines changed

7 files changed

+17
-0
lines changed

extensions/ql-vscode/src/remote-queries/gh-api/variant-analysis.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ export interface VariantAnalysis {
2424
actor_id: number,
2525
query_language: VariantAnalysisQueryLanguage,
2626
query_pack_url: string,
27+
created_at: string,
28+
updated_at: string,
2729
status: VariantAnalysisStatus,
30+
completed_at?: string,
2831
actions_workflow_run_id?: number,
2932
failure_reason?: VariantAnalysisFailureReason,
3033
scanned_repositories?: VariantAnalysisScannedRepository[],

extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,11 @@ export interface VariantAnalysis {
1515
repositoryLists?: string[],
1616
repositoryOwners?: string[],
1717
},
18+
createdAt: string,
19+
updatedAt: string,
1820
executionStartTime: number;
1921
status: VariantAnalysisStatus,
22+
completedAt?: string,
2023
actionsWorkflowRunId?: number,
2124
failureReason?: VariantAnalysisFailureReason,
2225
scannedRepos?: VariantAnalysisScannedRepository[],

extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,10 @@ export function processUpdatedVariantAnalysis(
5656
query: previousVariantAnalysis.query,
5757
databases: previousVariantAnalysis.databases,
5858
executionStartTime: previousVariantAnalysis.executionStartTime,
59+
createdAt: response.created_at,
60+
updatedAt: response.updated_at,
5961
status: processApiStatus(response.status),
62+
completedAt: response.completed_at,
6063
actionsWorkflowRunId: response.actions_workflow_run_id,
6164
scannedRepos: scannedRepos,
6265
skippedRepos: skippedRepos

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisAnalyzedRepos.spec.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ describe(VariantAnalysisAnalyzedRepos.name, () => {
2121
},
2222
databases: {},
2323
executionStartTime: 1611234567890,
24+
createdAt: '2021-01-21T13:09:27.890Z',
25+
updatedAt: '2021-01-21T13:09:27.890Z',
2426
status: VariantAnalysisStatus.InProgress,
2527
scannedRepos: [
2628
{

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisOutcomePanels.spec.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ describe(VariantAnalysisOutcomePanels.name, () => {
2020
},
2121
databases: {},
2222
executionStartTime: 1611234567890,
23+
createdAt: '2021-01-21T13:09:27.890Z',
24+
updatedAt: '2021-01-21T13:09:27.890Z',
2325
status: VariantAnalysisStatus.InProgress,
2426
scannedRepos: [
2527
{

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/gh-api/variant-analysis-api-response.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ export function createMockApiResponse(
2828
actor_id: faker.datatype.number(),
2929
query_language: VariantAnalysisQueryLanguage.Javascript,
3030
query_pack_url: 'https://example.com/foo',
31+
created_at: faker.date.recent().toISOString(),
32+
updated_at: faker.date.recent().toISOString(),
3133
status: status,
3234
actions_workflow_run_id: faker.datatype.number(),
3335
scanned_repositories: scannedRepos,

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ export function createMockVariantAnalysis(
2727
repositories: ['1', '2', '3'],
2828
},
2929
executionStartTime: faker.datatype.number(),
30+
createdAt: faker.date.recent().toISOString(),
31+
updatedAt: faker.date.recent().toISOString(),
3032
status: status,
3133
actionsWorkflowRunId: faker.datatype.number(),
3234
scannedRepos: scannedRepos,

0 commit comments

Comments
 (0)