Skip to content

Commit 5b17a84

Browse files
henrymerceredoardopirovano
authored andcommitted
Avoid resolve ml-models errors being logged during quick eval
Currently `resolve ml-models` only supports queryspecs, i.e. .ql, .qls, directory, and query pack specifications. Therefore quick evaluation within a library isn't supported.
1 parent 22873a2 commit 5b17a84

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

extensions/ql-vscode/src/run-queries.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,11 @@ export async function compileAndRunQueryAgainstDatabase(
789789
const metadata = await tryGetQueryMetadata(cliServer, qlProgram.queryPath);
790790

791791
let availableMlModels: cli.MlModelInfo[] = [];
792-
if (await cliServer.cliConstraints.supportsResolveMlModels()) {
792+
if (!initialInfo.queryPath.endsWith('.ql')) {
793+
void logger.log('Quick evaluation within a query library does not currently support using ML models. Continuing without any ML models.');
794+
} else if (!await cliServer.cliConstraints.supportsResolveMlModels()) {
795+
void logger.log('Resolving ML models is unsupported by this version of the CLI. Running the query without any ML models.');
796+
} else {
793797
try {
794798
availableMlModels = (await cliServer.resolveMlModels(diskWorkspaceFolders, initialInfo.queryPath)).models;
795799
if (availableMlModels.length) {

0 commit comments

Comments
 (0)