Skip to content

Commit 6aaa7d6

Browse files
committed
Simplify type checks for repositoryIds
1 parent e023037 commit 6aaa7d6

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

extensions/ql-vscode/src/pure/variant-analysis-filter-sort.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,16 +76,8 @@ export function compareWithResults(filterSortState: RepositoriesFilterSortState
7676
};
7777
}
7878

79-
function hasRepositoryIds(filterSortState: RepositoriesFilterSortState | RepositoriesFilterSortStateWithIds | undefined): filterSortState is RepositoriesFilterSortStateWithIds {
80-
if (!filterSortState) {
81-
return false;
82-
}
83-
84-
return 'repositoryIds' in filterSortState;
85-
}
86-
8779
function isFilterOnRepositoryIds(filterSortState: RepositoriesFilterSortState | RepositoriesFilterSortStateWithIds | undefined): filterSortState is RepositoriesFilterSortStateWithIds & Required<Pick<RepositoriesFilterSortStateWithIds, 'repositoryIds'>> {
88-
return hasRepositoryIds(filterSortState) && filterSortState.repositoryIds !== undefined && filterSortState.repositoryIds.length > 0;
80+
return !!filterSortState && 'repositoryIds' in filterSortState && filterSortState.repositoryIds !== undefined && filterSortState.repositoryIds.length > 0;
8981
}
9082

9183
// These define the behavior for undefined input values

0 commit comments

Comments
 (0)