Skip to content

Commit 7502fde

Browse files
committed
Remove open on GitHub item from cancelled local results
This will make a distinction between cancelled local and remote results, allowing us to hide the *Open Variant Analysis on GitHub* item from local failed/cancelled items. It also hides the *Show Evaluator Log* items for cancelled/failed remote queries.
1 parent 24652a8 commit 7502fde

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

extensions/ql-vscode/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@
752752
{
753753
"command": "codeQLQueryHistory.removeHistoryItem",
754754
"group": "9_qlCommands",
755-
"when": "viewItem == interpretedResultsItem || viewItem == rawResultsItem || viewItem == remoteResultsItem || viewItem == cancelledResultsItem"
755+
"when": "viewItem == interpretedResultsItem || viewItem == rawResultsItem || viewItem == remoteResultsItem || viewItem == cancelledResultsItem || viewItem == cancelledRemoteResultsItem"
756756
},
757757
{
758758
"command": "codeQLQueryHistory.setLabel",
@@ -827,7 +827,7 @@
827827
{
828828
"command": "codeQLQueryHistory.openOnGithub",
829829
"group": "9_qlCommands",
830-
"when": "viewItem == remoteResultsItem || viewItem == inProgressRemoteResultsItem || viewItem == cancelledResultsItem"
830+
"when": "viewItem == remoteResultsItem || viewItem == inProgressRemoteResultsItem || viewItem == cancelledRemoteResultsItem"
831831
},
832832
{
833833
"command": "codeQLQueryHistory.copyRepoList",

extensions/ql-vscode/src/query-history.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ export class HistoryTreeDataProvider extends DisposableObject implements TreeDat
189189
break;
190190
case QueryStatus.Failed:
191191
treeItem.iconPath = this.failedIconPath;
192-
treeItem.contextValue = 'cancelledResultsItem';
192+
treeItem.contextValue = element.t === 'local' ? 'cancelledResultsItem' : 'cancelledRemoteResultsItem';
193193
break;
194194
default:
195195
assertNever(element.status);

0 commit comments

Comments
 (0)