Skip to content

Commit a78eef4

Browse files
committed
Handle undefined URLs
1 parent e8348ac commit a78eef4

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

extensions/ql-vscode/src/remote-queries/remote-queries-markdown-generation.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,11 @@ function generateMarkdownForRawTableCell(
260260
case 'object':
261261
{
262262
const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix);
263-
cellValue = `[\`${convertNonPrintableChars(value.label)}\`](${url})`;
263+
if (url) {
264+
cellValue = `[\`${convertNonPrintableChars(value.label)}\`](${url})`;
265+
} else {
266+
cellValue = `\`${convertNonPrintableChars(value.label)}\``;
267+
}
264268
}
265269
break;
266270
}

extensions/ql-vscode/src/remote-queries/view/RawResultsTable.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,11 @@ const Cell = ({
4848
return <span>{convertNonPrintableChars(value.toString())}</span>;
4949
case 'object': {
5050
const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix);
51-
return <Link href={url}>{convertNonPrintableChars(value.label)}</Link>;
51+
if (url) {
52+
return <Link href={url}>{convertNonPrintableChars(value.label)}</Link>;
53+
} else {
54+
return <span>{convertNonPrintableChars(value.label)}</span>;
55+
}
5256
}
5357
}
5458
};

0 commit comments

Comments
 (0)