Skip to content

Commit b639f62

Browse files
committed
Don't run gulp for integration tests
We previously attempted to speed up no-workspace tests [1] but realised we still needed to run some setup steps to get the latest files [2]. Given that we already have `npm run watch` running in the background when we run our tests, we should be able to regenerate files on the fly. This means we can drop `gulp` from our setup steps when running integration tests. While there's still a danger that you forget to run `npm run watch` in the background, we think the massive speed up (10s -> 1s) is worth it as we add more and more tests to this extension. [1]: #1694 [2]: #1696
1 parent 3c860cf commit b639f62

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

extensions/ql-vscode/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1256,7 +1256,7 @@
12561256
"test": "npm-run-all -p test:*",
12571257
"test:unit": "mocha --config .mocharc.json test/pure-tests/**/*.ts",
12581258
"test:view": "jest",
1259-
"integration-setup": "rm -rf ./out/vscode-tests && gulp",
1259+
"integration-setup": "rm -rf ./out/vscode-tests",
12601260
"integration": "npm run integration-setup && node ./out/vscode-tests/run-integration-tests.js no-workspace,minimal-workspace",
12611261
"integration:no-workspace": "npm run integration-setup && node ./out/vscode-tests/run-integration-tests.js no-workspace",
12621262
"integration:minimal-workspace": "npm run integration-setup && node ./out/vscode-tests/run-integration-tests.js minimal-workspace",

0 commit comments

Comments
 (0)