Simplify and clarify Webpack font config

koesie10 · koesie10 · commit ba8b32078da1 · 2022-09-01T11:21:06.000+02:00
diff --git a/extensions/ql-vscode/gulpfile.ts/webpack.config.ts b/extensions/ql-vscode/gulpfile.ts/webpack.config.ts
@@ -57,13 +57,15 @@ export const config: webpack.Configuration = {
         ]
       },
       {
-        test: /\.(woff(2)?|ttf|eot|svg)$/,
+        test: /\.(woff(2)?|ttf|eot)$/,
         use: [
           {
             loader: 'file-loader',
             options: {
               name: '[name].[ext]',
               outputPath: 'fonts/',
+              // We need this to make Webpack use the correct path for the fonts.
+              // Without this, the CSS file will use `url([object Module])`
               esModule: false
             }
           },

Original file line number	Diff line number	Diff line change
`@@ -57,13 +57,15 @@ export const config: webpack.Configuration = {`
`57`	`57`	`]`
`58`	`58`	`},`
`59`	`59`	`{`
`60`		`- test: /\.(woff(2)?\|ttf\|eot\|svg)$/,`
	`60`	`+ test: /\.(woff(2)?\|ttf\|eot)$/,`
`61`	`61`	`use: [`
`62`	`62`	`{`
`63`	`63`	`loader: 'file-loader',`
`64`	`64`	`options: {`
`65`	`65`	`name: '[name].[ext]',`
`66`	`66`	`outputPath: 'fonts/',`
	`67`	`+ // We need this to make Webpack use the correct path for the fonts.`
	`68`	+ // Without this, the CSS file will use `url([object Module])`
`67`	`69`	`esModule: false`
`68`	`70`	`}`
`69`	`71`	`},`