Skip to content

Commit dad6467

Browse files
committed
Add controller repo to VariantAnalysis type
This adds the `controllerRepo` field to the `VariantAnalysis` shared type. This is technically a breaking change since the old history won't have this field and all calls on this will fail. However, the feature is not available so this should be fine.
1 parent 1cce7ae commit dad6467

File tree

10 files changed

+44
-10
lines changed

10 files changed

+44
-10
lines changed

extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { AnalysisAlert, AnalysisRawResults } from './analysis-result';
33

44
export interface VariantAnalysis {
55
id: number,
6-
controllerRepoId: number,
6+
controllerRepo: Repository;
77
query: {
88
name: string,
99
filePath: string,

extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export class VariantAnalysisMonitor extends DisposableObject {
5151

5252
variantAnalysisSummary = await ghApiClient.getVariantAnalysis(
5353
credentials,
54-
variantAnalysis.controllerRepoId,
54+
variantAnalysis.controllerRepo.id,
5555
variantAnalysis.id
5656
);
5757

extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@ export function processUpdatedVariantAnalysis(
5252

5353
const variantAnalysis: VariantAnalysis = {
5454
id: response.id,
55-
controllerRepoId: response.controller_repo.id,
55+
controllerRepo: {
56+
id: response.controller_repo.id,
57+
fullName: response.controller_repo.full_name,
58+
private: response.controller_repo.private,
59+
},
5660
query: previousVariantAnalysis.query,
5761
databases: previousVariantAnalysis.databases,
5862
executionStartTime: previousVariantAnalysis.executionStartTime,

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysis.stories.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ const Template: ComponentStory<typeof VariantAnalysisComponent> = (args) => (
2424

2525
const variantAnalysis: VariantAnalysisDomainModel = {
2626
id: 1,
27-
controllerRepoId: 1,
27+
controllerRepo: {
28+
id: 1,
29+
fullName: 'octodemo/variant-analysis-controller',
30+
private: false,
31+
},
2832
actionsWorkflowRunId: 789263,
2933
query: {
3034
name: 'Example query',

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisAnalyzedRepos.stories.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ export const Example = Template.bind({});
3737
Example.args = {
3838
variantAnalysis: {
3939
id: 1,
40-
controllerRepoId: 1,
40+
controllerRepo: {
41+
id: 1,
42+
fullName: 'octodemo/variant-analysis-controller',
43+
private: false,
44+
},
4145
query: {
4246
name: 'Query name',
4347
filePath: 'example.ql',

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisHeader.stories.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,11 @@ const Template: ComponentStory<typeof VariantAnalysisHeader> = (args) => (
6868

6969
const buildVariantAnalysis = (data: Partial<VariantAnalysis>) => ({
7070
id: 1,
71-
controllerRepoId: 1,
71+
controllerRepo: {
72+
id: 1,
73+
fullName: 'octodemo/variant-analysis-controller',
74+
private: false,
75+
},
7276
query: {
7377
name: 'Query name',
7478
filePath: 'example.ql',

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisOutcomePanels.stories.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ const Template: ComponentStory<typeof VariantAnalysisOutcomePanels> = (args) =>
3030

3131
const buildVariantAnalysis = (data: Partial<VariantAnalysis>) => ({
3232
id: 1,
33-
controllerRepoId: 1,
33+
controllerRepo: {
34+
id: 1,
35+
fullName: 'octodemo/variant-analysis-controller',
36+
private: false,
37+
},
3438
query: {
3539
name: 'Query name',
3640
filePath: 'example.ql',

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisAnalyzedRepos.spec.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ import { VariantAnalysisAnalyzedRepos, VariantAnalysisAnalyzedReposProps } from
1111
describe(VariantAnalysisAnalyzedRepos.name, () => {
1212
const defaultVariantAnalysis = {
1313
id: 1,
14-
controllerRepoId: 1,
14+
controllerRepo: {
15+
id: 1,
16+
fullName: 'octodemo/variant-analysis-controller',
17+
private: false,
18+
},
1519
actionsWorkflowRunId: 789263,
1620
query: {
1721
name: 'Example query',

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisOutcomePanels.spec.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ import { VariantAnalysisOutcomePanelProps, VariantAnalysisOutcomePanels } from '
1010
describe(VariantAnalysisOutcomePanels.name, () => {
1111
const defaultVariantAnalysis = {
1212
id: 1,
13-
controllerRepoId: 1,
13+
controllerRepo: {
14+
id: 1,
15+
fullName: 'octodemo/variant-analysis-controller',
16+
private: false,
17+
},
1418
actionsWorkflowRunId: 789263,
1519
query: {
1620
name: 'Example query',

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/shared/variant-analysis.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,13 @@ export function createMockVariantAnalysis(
1616
): VariantAnalysis {
1717
const variantAnalysis: VariantAnalysis = {
1818
id: faker.datatype.number(),
19-
controllerRepoId: faker.datatype.number(),
19+
controllerRepo: {
20+
id: faker.datatype.number(),
21+
fullName: 'github/' + faker.datatype.hexadecimal({
22+
prefix: '',
23+
}),
24+
private: faker.datatype.boolean(),
25+
},
2026
query: {
2127
name: 'a-query-name',
2228
filePath: 'a-query-file-path',

0 commit comments

Comments
 (0)