Fix newline handling for cross-platform logs

We were splitting JSONL records based on the current OS newline sequence. In order to handle reading of logs from the opposite OS, I've switched our split to handle both flavors of line ending. This originally showed up as log parser unit tests failing on Windows (the checked-in log used Unix line endings), but could affect real world usage as well.

Author: Dave Bartolomeo

extensions/ql-vscode/src/pure/log-summary-parser.ts

@@ -1,33 +1,31 @@
-import * as os from 'os';
-
 // TODO(angelapwen): Only load in necessary information and
-// location in bytes for this log to save memory. 
+// location in bytes for this log to save memory.
 export interface EvaluatorLogData {
     queryCausingWork: string;
     predicateName: string;
     millis: number;
     resultSize: number;
     ra: Pipelines;
 }
-  
+
 interface Pipelines {
-    // Key: pipeline identifier; Value: array of pipeline steps 
+    // Key: pipeline identifier; Value: array of pipeline steps
     pipelineNamesToSteps: Map<string, string[]>;
 }
-  
+
 /**
  * A pure method that parses a string of evaluator log summaries into
- * an array of EvaluatorLogData objects. 
- * 
+ * an array of EvaluatorLogData objects.
+ *
  */
  export function parseVisualizerData(logSummary: string): EvaluatorLogData[] {
     // Remove newline delimiters because summary is in .jsonl format.
-    const jsonSummaryObjects: string[] = logSummary.split(os.EOL + os.EOL);
+    const jsonSummaryObjects: string[] = logSummary.split(/\r?\n\r?\n/g);
     const visualizerData: EvaluatorLogData[] = [];
-  
+
     for (const obj of jsonSummaryObjects) {
       const jsonObj = JSON.parse(obj);
-  
+
       // Only convert log items that have an RA and millis field
       if (jsonObj.ra !== undefined && jsonObj.millis !== undefined) {
         const newLogData: EvaluatorLogData = {
@@ -39,6 +37,6 @@ interface Pipelines {
         };
         visualizerData.push(newLogData);
       }
-    } 
+    }
     return visualizerData;
-}
+}