Extract MRVA view title generation to method

We had duplicated logic for generating the variant analysis view title.
This extracts it to a single method so the title are always in sync.

Author: koesie10

extensions/ql-vscode/src/remote-queries/variant-analysis-view.ts

@@ -52,7 +52,7 @@ export class VariantAnalysisView
     });
 
     const panel = await this.getPanel();
-    panel.title = `${variantAnalysis.query.name} - CodeQL Query Results`;
+    panel.title = this.getTitle(variantAnalysis);
   }
 
   public async updateRepoState(
@@ -88,9 +88,7 @@ export class VariantAnalysisView
 
     return {
       viewId: VariantAnalysisView.viewType,
-      title: variantAnalysis
-        ? `${variantAnalysis.query.name} - CodeQL Query Results`
-        : `Variant analysis ${this.variantAnalysisId} - CodeQL Query Results`,
+      title: this.getTitle(variantAnalysis),
       viewColumn: ViewColumn.Active,
       preserveFocus: true,
       view: "variant-analysis",
@@ -189,4 +187,10 @@ export class VariantAnalysisView
       repoStates,
     });
   }
+
+  private getTitle(variantAnalysis: VariantAnalysis | undefined): string {
+    return variantAnalysis
+      ? `${variantAnalysis.query.name} - CodeQL Query Results`
+      : `Variant analysis ${this.variantAnalysisId} - CodeQL Query Results`;
+  }
 }