Skip to content

Commit f90d538

Browse files
committed
Add feature flag for framework mode
1 parent 72a91ef commit f90d538

File tree

4 files changed

+27
-11
lines changed

4 files changed

+27
-11
lines changed

extensions/ql-vscode/src/config.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -714,6 +714,7 @@ export function showQueriesPanel(): boolean {
714714

715715
const DATA_EXTENSIONS = new Setting("dataExtensions", ROOT_SETTING);
716716
const LLM_GENERATION = new Setting("llmGeneration", DATA_EXTENSIONS);
717+
const FRAMEWORK_MODE = new Setting("frameworkMode", DATA_EXTENSIONS);
717718
const DISABLE_AUTO_NAME_EXTENSION_PACK = new Setting(
718719
"disableAutoNameExtensionPack",
719720
DATA_EXTENSIONS,
@@ -723,6 +724,10 @@ export function showLlmGeneration(): boolean {
723724
return !!LLM_GENERATION.getValue<boolean>();
724725
}
725726

727+
export function enableFrameworkMode(): boolean {
728+
return !!FRAMEWORK_MODE.getValue<boolean>();
729+
}
730+
726731
export function disableAutoNameExtensionPack(): boolean {
727732
return !!DISABLE_AUTO_NAME_EXTENSION_PACK.getValue<boolean>();
728733
}

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ import {
4949
createAutoModelRequest,
5050
parsePredictedClassifications,
5151
} from "./auto-model";
52-
import { showLlmGeneration } from "../config";
52+
import { enableFrameworkMode, showLlmGeneration } from "../config";
5353
import { getAutoModelUsages } from "./auto-model-usages-query";
5454
import { getOnDiskWorkspaceFolders } from "../common/vscode/workspace-folders";
5555
import { Mode } from "./shared/mode";
@@ -168,6 +168,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
168168
t: "setDataExtensionEditorViewState",
169169
viewState: {
170170
extensionPack: this.extensionPack,
171+
enableFrameworkMode: enableFrameworkMode(),
171172
showLlmButton: showLlmGeneration(),
172173
mode: this.mode,
173174
},

extensions/ql-vscode/src/data-extensions-editor/shared/view-state.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { Mode } from "./mode";
33

44
export interface DataExtensionEditorViewState {
55
extensionPack: ExtensionPack;
6+
enableFrameworkMode: boolean;
67
showLlmButton: boolean;
78
mode: Mode;
89
}

extensions/ql-vscode/src/view/data-extensions-editor/DataExtensionsEditor.tsx

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -204,16 +204,25 @@ export function DataExtensionsEditor({
204204
<div>
205205
{percentFormatter.format(unModeledPercentage / 100)} unmodeled
206206
</div>
207-
<div>
208-
Mode:{" "}
209-
{viewState?.mode === Mode.Framework ? "Framework" : "Application"}
210-
</div>
211-
<div>
212-
<LinkIconButton onClick={onSwitchModeClick}>
213-
<span slot="start" className="codicon codicon-library"></span>
214-
Switch mode
215-
</LinkIconButton>
216-
</div>
207+
{viewState?.enableFrameworkMode && (
208+
<>
209+
<div>
210+
Mode:{" "}
211+
{viewState?.mode === Mode.Framework
212+
? "Framework"
213+
: "Application"}
214+
</div>
215+
<div>
216+
<LinkIconButton onClick={onSwitchModeClick}>
217+
<span
218+
slot="start"
219+
className="codicon codicon-library"
220+
></span>
221+
Switch mode
222+
</LinkIconButton>
223+
</div>
224+
</>
225+
)}
217226
</DetailsContainer>
218227

219228
<EditorContainer>

0 commit comments

Comments
 (0)