Skip to content

Commit fd2b91d

Browse files
committed
Remove casting to QueryHistoryConfig
1 parent dd4df01 commit fd2b91d

File tree

4 files changed

+27
-16
lines changed

4 files changed

+27
-16
lines changed

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/history-item-label-provider.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ describe("HistoryItemLabelProvider", () => {
2222
beforeEach(() => {
2323
config = {
2424
format: "xxx %q xxx",
25-
} as unknown as QueryHistoryConfig;
25+
ttlInMillis: 0,
26+
onDidChangeConfiguration: jest.fn(),
27+
};
2628
labelProvider = new HistoryItemLabelProvider(config);
2729
});
2830

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/history-tree-data-provider.test.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@ import { join } from "path";
22
import * as vscode from "vscode";
33

44
import { extLogger } from "../../../../src/common";
5-
import {
6-
QueryHistoryConfig,
7-
QueryHistoryConfigListener,
8-
} from "../../../../src/config";
5+
import { QueryHistoryConfigListener } from "../../../../src/config";
96
import { LocalQueryInfo } from "../../../../src/query-results";
107
import { DatabaseManager } from "../../../../src/local-databases";
118
import { tmpDir } from "../../../../src/helpers";
@@ -121,8 +118,10 @@ describe("HistoryTreeDataProvider", () => {
121118
]);
122119

123120
labelProvider = new HistoryItemLabelProvider({
124-
/**/
125-
} as QueryHistoryConfig);
121+
format: "",
122+
ttlInMillis: 0,
123+
onDidChangeConfiguration: jest.fn(),
124+
});
126125
historyTreeDataProvider = new HistoryTreeDataProvider(labelProvider);
127126
});
128127

@@ -432,7 +431,11 @@ describe("HistoryTreeDataProvider", () => {
432431
extensionPath: vscode.Uri.file("/x/y/z").fsPath,
433432
} as vscode.ExtensionContext,
434433
configListener,
435-
new HistoryItemLabelProvider({} as QueryHistoryConfig),
434+
new HistoryItemLabelProvider({
435+
format: "",
436+
ttlInMillis: 0,
437+
onDidChangeConfiguration: jest.fn(),
438+
}),
436439
doCompareCallback,
437440
);
438441
(qhm.treeDataProvider as any).history = [...allHistory];

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history-manager.test.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@ import * as vscode from "vscode";
33

44
import { extLogger } from "../../../../src/common";
55
import { QueryHistoryManager } from "../../../../src/query-history/query-history-manager";
6-
import {
7-
QueryHistoryConfig,
8-
QueryHistoryConfigListener,
9-
} from "../../../../src/config";
6+
import { QueryHistoryConfigListener } from "../../../../src/config";
107
import { LocalQueryInfo } from "../../../../src/query-results";
118
import { DatabaseManager } from "../../../../src/local-databases";
129
import { tmpDir } from "../../../../src/helpers";
@@ -1159,7 +1156,11 @@ describe("QueryHistoryManager", () => {
11591156
extensionPath: vscode.Uri.file("/x/y/z").fsPath,
11601157
} as vscode.ExtensionContext,
11611158
configListener,
1162-
new HistoryItemLabelProvider({} as QueryHistoryConfig),
1159+
new HistoryItemLabelProvider({
1160+
format: "",
1161+
ttlInMillis: 0,
1162+
onDidChangeConfiguration: jest.fn(),
1163+
}),
11631164
doCompareCallback,
11641165
);
11651166
(qhm.treeDataProvider as any).history = [...allHistory];

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/variant-analysis-history.test.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
import { join } from "path";
1010

1111
import { commands, ExtensionContext, Uri } from "vscode";
12-
import { QueryHistoryConfig } from "../../../../src/config";
1312
import { DatabaseManager } from "../../../../src/local-databases";
1413
import { tmpDir, walkDirectory } from "../../../../src/helpers";
1514
import { DisposableBucket } from "../../disposable-bucket";
@@ -82,9 +81,15 @@ describe("Variant Analyses and QueryHistoryManager", () => {
8281
extensionPath: EXTENSION_PATH,
8382
}),
8483
{
84+
format: "",
85+
ttlInMillis: 0,
8586
onDidChangeConfiguration: () => new DisposableBucket(),
86-
} as unknown as QueryHistoryConfig,
87-
new HistoryItemLabelProvider({} as QueryHistoryConfig),
87+
},
88+
new HistoryItemLabelProvider({
89+
format: "",
90+
ttlInMillis: 0,
91+
onDidChangeConfiguration: jest.fn(),
92+
}),
8893
asyncNoop,
8994
);
9095
disposables.push(qhm);

0 commit comments

Comments
 (0)