Skip to content

Adjust test-plan for code search #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norascheuch merged 2 commits into from
Mar 3, 2025
Merged

Adjust test-plan for code search #3948

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7294480
Add expected http error to code search test plan
norascheuch Mar 3, 2025
f201a88
Merge comments
norascheuch Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/test-plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ This requires running a MRVA query and seeing the results view.
1. Make changes via config file (ensure JSON schema is helping out)
1. Close and re-open VS Code (ensure lists are there)
1. Collapse/expand tree nodes
1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This should show a rate limiting notification after a while but eventually populate the list with roughly 770 items.
1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories.

Copy link

Copilot AI Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a typo ('Whene') in the added instruction. Consider correcting it to 'When'.

Suggested change
1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories.
1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. When run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@charisk charisk Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories.
1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when it is run for the first time. If so, try again. When run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories.

Error cases that trigger an error notification:

Expand Down
Loading