Removed two more instances of 'msg->getPlayerIndex'.

Caball009 · Caball009 · commit 7c8b814f2a21 · 2026-03-07T20:34:08.000+01:00
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp
@@ -410,7 +410,7 @@ void GameLogic::logicMessageDispatcher( GameMessage *msg, void *userData )
 	if (commandName.isNotEmpty() /*&& msg->getType() != GameMessage::MSG_FRAME_TICK*/)
 	{
 		DEBUG_LOG(("Frame %d: GameLogic::logicMessageDispatcher() saw a %s from player %d (%ls)", getFrame(), commandName.str(),
-			msg->getPlayerIndex(), thisPlayer->getPlayerDisplayName().str()));
+			thisPlayer->getPlayerIndex(), thisPlayer->getPlayerDisplayName().str()));
 	}
 #endif
 #endif // DEBUG_LOGGING
@@ -1987,11 +1987,10 @@ void GameLogic::logicMessageDispatcher( GameMessage *msg, void *userData )
 #endif
 				}
 
-				//UnsignedInt oldCRC = m_cachedCRCs[msg->getPlayerIndex()];
 				UnsignedInt newCRC = msg->getArgument(0)->integer;
 				//DEBUG_LOG(("Received CRC of %8.8X from %ls on frame %d", newCRC,
 					//thisPlayer->getPlayerDisplayName().str(), m_frame));
-				m_cachedCRCs[thisPlayer->getPlayerIndex()] = newCRC; // to mask problem: = (oldCRC < newCRC)?newCRC:oldCRC;
+				m_cachedCRCs[thisPlayer->getPlayerIndex()] = newCRC;
 			}
 			else if (TheRecorder && TheRecorder->isPlaybackMode())
 			{

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ void GameLogic::logicMessageDispatcher( GameMessage msg, void userData )`
`410`	`410`	`if (commandName.isNotEmpty() /&& msg->getType() != GameMessage::MSG_FRAME_TICK/)`
`411`	`411`	`{`
`412`	`412`	`DEBUG_LOG(("Frame %d: GameLogic::logicMessageDispatcher() saw a %s from player %d (%ls)", getFrame(), commandName.str(),`
`413`		`- msg->getPlayerIndex(), thisPlayer->getPlayerDisplayName().str()));`
	`413`	`+ thisPlayer->getPlayerIndex(), thisPlayer->getPlayerDisplayName().str()));`
`414`	`414`	`}`
`415`	`415`	`#endif`
`416`	`416`	`#endif // DEBUG_LOGGING`
`@@ -1987,11 +1987,10 @@ void GameLogic::logicMessageDispatcher( GameMessage msg, void userData )`
`1987`	`1987`	`#endif`
`1988`	`1988`	`}`
`1989`	`1989`
`1990`		`- //UnsignedInt oldCRC = m_cachedCRCs[msg->getPlayerIndex()];`
`1991`	`1990`	`UnsignedInt newCRC = msg->getArgument(0)->integer;`
`1992`	`1991`	`//DEBUG_LOG(("Received CRC of %8.8X from %ls on frame %d", newCRC,`
`1993`	`1992`	`//thisPlayer->getPlayerDisplayName().str(), m_frame));`
`1994`		`- m_cachedCRCs[thisPlayer->getPlayerIndex()] = newCRC; // to mask problem: = (oldCRC < newCRC)?newCRC:oldCRC;`
	`1993`	`+ m_cachedCRCs[thisPlayer->getPlayerIndex()] = newCRC;`
`1995`	`1994`	`}`
`1996`	`1995`	`else if (TheRecorder && TheRecorder->isPlaybackMode())`
`1997`	`1996`	`{`