Commit 0545068
fix(compile): address PR review feedback on migration framework
Four findings from the Rust PR Reviewer bot:
1. check_pipeline's bail message had a redundant "error:" prefix that
produced "Error: error: ..." once anyhow's top-level handler added
its own "Error:" wrapper. Drop the prefix and reformat the hint
onto an indented continuation line.
2. compile_pipeline_inner did a redundant serde_yaml::from_value
round-trip just to satisfy ParsedSource.front_matter, even though
perform_source_rewrite_if_needed never reads that field. Refactor
the helper to take the four primitive fields it actually uses
(mapping, body_raw, source_sha256, migrations) instead of the full
struct. reconstruct_source likewise takes individual fields now.
3. Misleading comment in tests/migration_tests.rs claimed a
"thread-local counter" was used; only a nanosecond timestamp was.
Replaced rand_suffix() with timestamp + AtomicU64 monotonic seq so
parallel tests scheduled in the same nanosecond always get
distinct dirs.
4. Leading whitespace before the opening `---` was silently stripped
on migration rewrite. parse_markdown_detailed already tolerates it
on read; capture it as a new ParsedSource.leading_whitespace field
and emit it from reconstruct_source so byte-faithful preservation
extends to whitespace prefixes (BOM-stripped editor blank lines,
etc.).
All 1369 tests still pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent a90f543 commit 0545068
4,313 files changed
Lines changed: 1216283 additions & 41 deletions
File tree
- scripts/ado-script
- dist
- gate
- prompt
- node_modules
- .bin
- .vite/vitest
- @apidevtools/json-schema-ref-parser
- dist
- lib
- parsers
- resolvers
- types
- util
- lib
- parsers
- resolvers
- types
- util
- @esbuild/darwin-arm64
- bin
- @jridgewell/sourcemap-codec
- dist
- src
- types
- @jsdevtools/ono
- cjs
- esm
- @rollup/rollup-darwin-arm64
- @types
- estree
- json-schema
- lodash
- common
- fp
- node
- assert
- compatibility
- dns
- fs
- readline
- stream
- timers
- ts5.6
- web-globals
- @vercel/ncc
- dist
- ncc
- buildin
- loaders
- typescript/lib
- @vitest
- expect
- dist
- mocker
- dist
- pretty-format
- dist
- runner
- dist
- snapshot
- dist
- spy
- dist
- utils
- dist
- argparse
- lib
- assertion-error
- azure-devops-node-api
- handlers
- interfaces
- common
- opensource/node-http-ntlm
- cac
- deno
- dist
- call-bind-apply-helpers
- .github
- test
- call-bound
- .github
- test
- chai
- lib
- chai
- core
- interface
- utils
- check-error
- debug
- src
- deep-eql
- des.js
- lib
- des
- test
- dunder-proto
- .github
- test
- es-define-property
- .github
- test
- es-errors
- .github
- test
- es-module-lexer
- dist
- types
- es-object-atoms
- .github
- test
- esbuild
- bin
- lib
- estree-walker
- src
- types
- expect-type
- dist
- fdir
- dist
- fsevents
- function-bind
- .github
- test
- get-intrinsic
- .github
- test
- get-proto
- .github
- test
- gopd
- .github
- test
- has-symbols
- .github
- test
- shams
- hasown
- .github
- inherits
- is-extglob
- is-glob
- js-md4
- build
- doc
- fonts
- scripts
- prettify
- styles
- src
- tests
- js-yaml
- bin
- dist
- lib
- schema
- type
- json-schema-to-typescript
- .github/workflows
- dist/src
- types
- src
- types
- lodash
- fp
- loupe
- lib
- magic-string
- dist
- math-intrinsics
- .github
- constants
- test
- minimalistic-assert
- minimist
- .github
- example
- test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments