fix(compile): address PR review feedback for job/stage targets

- Fix path corruption: use Path::with_extension instead of
  string replace to derive .lock.yml paths in header comments
  (avoids corrupting directory names containing '.md')
- Fix repos header docs: only check front_matter.repositories
  (populated by resolve_repos() before compile) instead of
  also checking front_matter.repos (raw input, may be empty)
- Fix Unicode in stage prefix: use is_ascii_alphanumeric() to
  split on non-ASCII characters, ensuring ADO-valid identifiers
  (ADO requires [A-Za-z0-9_] for job/stage names)
- Add test for Unicode stripping in generate_stage_prefix

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jamesadevine

src/compile/common.rs

@@ -1008,9 +1008,10 @@ pub const DEFAULT_POOL: &str = "AZS-1ES-L-MMS-ubuntu-22.04";
 /// - `"my-agent-123"` → `"MyAgent123"`
 /// - `""` → `"Agent"` (fallback)
 /// - `"123start"` → `"_123start"` (prefix underscore for leading digit)
+/// - `"über-agent"` → `"BerAgent"` (non-ASCII stripped; ADO requires `[A-Za-z0-9_]`)
 pub fn generate_stage_prefix(name: &str) -> String {
     let pascal: String = name
-        .split(|c: char| !c.is_alphanumeric())
+        .split(|c: char| !c.is_ascii_alphanumeric())
         .filter(|s| !s.is_empty())
         .map(|word| {
             let mut chars = word.chars();

src/compile/job.rs

@@ -115,27 +115,28 @@ impl Compiler for JobCompiler {
 /// Generate the header comment block for job-level templates.
 fn generate_job_header(input_path: &Path, front_matter: &FrontMatter) -> String {
     let base_header = generate_header_comment(input_path);
-    let source_path = input_path
+    let lock_path = input_path
+        .with_extension("lock.yml")
         .to_string_lossy()
         .replace('\\', "/");
 
     let mut header = base_header;
     header.push_str("#\n");
     header.push_str("# Job-level ADO template. Include in your pipeline:\n");
     header.push_str("#\n");
-    header.push_str(&format!("#   jobs:\n"));
-    header.push_str(&format!("#     - template: {}\n", source_path.replace(".md", ".lock.yml")));
+    header.push_str("#   jobs:\n");
+    header.push_str(&format!("#     - template: {}\n", lock_path));
     header.push_str("#\n");
     header.push_str("# Or inside a stage in a multi-stage pipeline:\n");
     header.push_str("#\n");
     header.push_str("#   stages:\n");
     header.push_str("#     - stage: AgenticReview\n");
     header.push_str("#       dependsOn: Build\n");
     header.push_str("#       jobs:\n");
-    header.push_str(&format!("#         - template: {}\n", source_path.replace(".md", ".lock.yml")));
+    header.push_str(&format!("#         - template: {}\n", lock_path));
 
     // Document required resources if agent uses repos
-    if !front_matter.repos.is_empty() || !front_matter.repositories.is_empty() {
+    if !front_matter.repositories.is_empty() {
         header.push_str("#\n");
         header.push_str("# Add these repositories to your pipeline's resources: block:\n");
         header.push_str("#\n");
@@ -186,4 +187,10 @@ mod tests {
     fn test_generate_stage_prefix_underscores() {
         assert_eq!(generate_stage_prefix("code_review_agent"), "CodeReviewAgent");
     }
+
+    #[test]
+    fn test_generate_stage_prefix_unicode_stripped() {
+        // ADO identifiers require [A-Za-z0-9_]; non-ASCII chars are split points
+        assert_eq!(generate_stage_prefix("über-agent"), "BerAgent");
+    }
 }

src/compile/stage.rs

@@ -123,7 +123,8 @@ impl Compiler for StageCompiler {
 /// Generate the header comment block for stage-level templates.
 fn generate_stage_header(input_path: &Path, front_matter: &FrontMatter) -> String {
     let base_header = generate_header_comment(input_path);
-    let source_path = input_path
+    let lock_path = input_path
+        .with_extension("lock.yml")
         .to_string_lossy()
         .replace('\\', "/");
 
@@ -132,12 +133,12 @@ fn generate_stage_header(input_path: &Path, front_matter: &FrontMatter) -> Strin
     header.push_str("# Stage-level ADO template. Include in your pipeline:\n");
     header.push_str("#\n");
     header.push_str("#   stages:\n");
-    header.push_str(&format!("#     - template: {}\n", source_path.replace(".md", ".lock.yml")));
+    header.push_str(&format!("#     - template: {}\n", lock_path));
     header.push_str("#       dependsOn: Build\n");
     header.push_str("#       condition: succeeded()\n");
 
     // Document required resources if agent uses repos
-    if !front_matter.repos.is_empty() || !front_matter.repositories.is_empty() {
+    if !front_matter.repositories.is_empty() {
         header.push_str("#\n");
         header.push_str("# Add these repositories to your pipeline's resources: block:\n");
         header.push_str("#\n");