test: reduce and improve tests in compiler_tests.rs (section 3) (#1448)

- Remove test_network_allow_trailing_wildcard_fails: duplicate of
  test_network_allow_mid_wildcard_fails — both test the same
  !host.starts_with("*.") branch in validate_dns_domain with inputs
  that produce the same error path and message.
- Rewrite test_parameters_no_unreplaced_markers → renamed to
  test_parameters_coexist_with_cache_memory_clear_memory: the original
  only asserted no unreplaced markers (a meta-property of compilation).
  The rewrite adds meaningful assertions that the user-defined param
  (myParam) and the auto-injected clearMemory param both appear exactly
  once in the output, making it a real regression guard for the
  parameters + cache-memory combination.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: github-actions[bot]

tests/compiler_tests.rs

@@ -2217,9 +2217,14 @@ Do the thing.
     let _ = fs::remove_dir_all(&temp_dir);
 }
 
-/// Test that parameters block has no unreplaced markers
+/// Test that user-defined parameters and cache-memory auto-injected clearMemory coexist
+///
+/// Verifies that when a pipeline defines its own parameters AND cache-memory, the
+/// compiled output contains both the user-defined parameter and the auto-injected
+/// `clearMemory` parameter without either clobbering the other. Also guards that
+/// no unreplaced `{{ }}` markers remain after compilation.
 #[test]
-fn test_parameters_no_unreplaced_markers() {
+fn test_parameters_coexist_with_cache_memory_clear_memory() {
     let temp_dir = std::env::temp_dir().join(format!(
         "agentic-pipeline-params-markers-{}",
         std::process::id()
@@ -2228,7 +2233,7 @@ fn test_parameters_no_unreplaced_markers() {
 
     let input = r#"---
 name: "Markers Agent"
-description: "Tests no unreplaced markers with parameters"
+description: "Tests user param + cache-memory clearMemory coexistence"
 parameters:
   - name: myParam
     type: string
@@ -2265,7 +2270,33 @@ tools:
 
     let compiled = fs::read_to_string(&output_path).unwrap();
 
-    // Verify no unreplaced {{ markers }} remain (excluding ${{ }} which are ADO expressions)
+    // User-defined parameter must be present
+    assert!(
+        compiled.contains("name: myParam"),
+        "Should contain user-defined 'myParam' parameter"
+    );
+    assert!(
+        compiled.contains("default: hello"),
+        "Should contain user-defined default value"
+    );
+
+    // cache-memory must auto-inject clearMemory alongside the user param
+    assert!(
+        compiled.contains("name: clearMemory"),
+        "Should auto-inject clearMemory parameter when cache-memory is enabled"
+    );
+    assert!(
+        compiled.contains("displayName: Clear agent memory"),
+        "clearMemory should carry the standard displayName"
+    );
+
+    // Neither parameter should shadow the other — both must appear
+    let param_count = compiled.matches("name: myParam").count();
+    assert_eq!(param_count, 1, "myParam should appear exactly once");
+    let clear_count = compiled.matches("name: clearMemory").count();
+    assert_eq!(clear_count, 1, "clearMemory should appear exactly once");
+
+    // No unreplaced {{ markers }} should remain (excluding ${{ }} ADO expressions)
     for line in compiled.lines() {
         let stripped = line.replace("${{", "");
         assert!(
@@ -2333,55 +2364,6 @@ network:
     let _ = fs::remove_dir_all(&temp_dir);
 }
 
-/// Test that network.allowed with a trailing wildcard (example.*) fails compilation
-#[test]
-fn test_network_allow_trailing_wildcard_fails() {
-    let temp_dir = std::env::temp_dir().join(format!(
-        "agentic-pipeline-network-trailing-wildcard-{}",
-        std::process::id()
-    ));
-    fs::create_dir_all(&temp_dir).expect("Failed to create temp directory");
-
-    let input = r#"---
-name: "Network Trailing Wildcard Agent"
-description: "Agent with trailing wildcard in network.allowed"
-network:
-  allowed:
-    - "example.*"
----
-
-## Test
-"#;
-
-    let input_path = temp_dir.join("network-trailing-wildcard.md");
-    let output_path = temp_dir.join("network-trailing-wildcard.yml");
-    fs::write(&input_path, input).unwrap();
-
-    let binary_path = PathBuf::from(env!("CARGO_BIN_EXE_ado-aw"));
-    let output = std::process::Command::new(&binary_path)
-        .args([
-            "compile",
-            input_path.to_str().unwrap(),
-            "-o",
-            output_path.to_str().unwrap(),
-        ])
-        .output()
-        .expect("Failed to run compiler");
-
-    assert!(
-        !output.status.success(),
-        "Compiler should fail for trailing wildcard 'example.*'"
-    );
-
-    let stderr = String::from_utf8_lossy(&output.stderr);
-    assert!(
-        stderr.contains("unsupported position"),
-        "Error message should mention unsupported position: {stderr}"
-    );
-
-    let _ = fs::remove_dir_all(&temp_dir);
-}
-
 /// Test that network.allowed with a mid-string wildcard (ex*ample.com) fails compilation
 #[test]
 fn test_network_allow_mid_wildcard_fails() {