fix(ado-script): exclude smoke test from default vitest run; consolidate shared tests

- Add vitest.config.ts with `include: ["src/**/*.test.ts"]` so the
  default `npm test` no longer picks up test/smoke.test.ts (which
  requires the ncc bundle to exist and was failing in CI before the
  build step ran).
- Add vitest.config.smoke.ts targeting test/ for the smoke run.
- Wire `npm run test:smoke` and the CI Smoke-test step to use the new
  smoke config (`vitest run -c vitest.config.smoke.ts`).
- Move shared module tests under src/shared/__tests__/ to mirror the
  layout used by src/gate/__tests__/. Update relative imports
  (./foo.js → ../foo.js) and the vi.mock path in ado-client.test.ts.

Validation:
- `npm test` → 171/171 ✅ (smoke excluded)
- `npx vitest run -c vitest.config.smoke.ts` after `npm run build`
  → 2/2 ✅
- `npm run typecheck` ✅

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jamesadevine

.github/workflows/ado-script.yml

@@ -60,7 +60,7 @@ jobs:
 
       - name: Smoke-test bundle
         working-directory: scripts/ado-script
-        run: npx vitest run test/smoke.test.ts
+        run: npx vitest run -c vitest.config.smoke.ts
 
       - name: E2E gate test
         run: cargo test --test gate_e2e -- --ignored --nocapture

scripts/ado-script/package.json

@@ -12,7 +12,7 @@
     "build:check": "ls -lh ../gate.js && wc -c ../gate.js",
     "codegen": "mkdir -p schema && cargo run --quiet --manifest-path ../../Cargo.toml -- export-gate-schema --output schema/gate-spec.schema.json && npx json2ts schema/gate-spec.schema.json -o src/shared/types.gen.ts --bannerComment \"// AUTO-GENERATED from Rust IR via cargo run -- export-gate-schema. Do not edit; run npm run codegen.\"",
     "test": "vitest run",
-    "test:smoke": "npm run build && vitest run test/smoke.test.ts",
+    "test:smoke": "npm run build && vitest run -c vitest.config.smoke.ts",
     "lint": "echo TODO",
     "typecheck": "tsc --noEmit"
   },

…ado-script/src/shared/ado-client.test.ts …/src/shared/__tests__/ado-client.test.tsscripts/ado-script/src/shared/ado-client.test.ts renamed to scripts/ado-script/src/shared/__tests__/ado-client.test.ts scripts/ado-script/src/shared/ado-client.test.ts renamed to scripts/ado-script/src/shared/__tests__/ado-client.test.ts

@@ -19,7 +19,7 @@ const { mockGitApi, mockBuildApi, mockWebApi, mockGetWebApi } = vi.hoisted(() =>
   return { mockGitApi, mockBuildApi, mockWebApi, mockGetWebApi };
 });
 
-vi.mock("./auth.js", () => ({
+vi.mock("../auth.js", () => ({
   getWebApi: mockGetWebApi,
   _resetCacheForTesting: vi.fn(),
 }));
@@ -30,7 +30,7 @@ import {
   getIterationChanges,
   cancelBuild,
   withRetry,
-} from "./ado-client.js";
+} from "../ado-client.js";
 
 describe("ado-client", () => {
   beforeEach(() => {

…ripts/ado-script/src/shared/auth.test.ts …script/src/shared/__tests__/auth.test.tsscripts/ado-script/src/shared/auth.test.ts renamed to scripts/ado-script/src/shared/__tests__/auth.test.ts scripts/ado-script/src/shared/auth.test.ts renamed to scripts/ado-script/src/shared/__tests__/auth.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import { getWebApi, _resetCacheForTesting } from "./auth.js";
+import { getWebApi, _resetCacheForTesting } from "../auth.js";
 
 describe("getWebApi", () => {
   const originalEnv = { ...process.env };

…/ado-script/src/shared/env-facts.test.ts …t/src/shared/__tests__/env-facts.test.tsscripts/ado-script/src/shared/env-facts.test.ts renamed to scripts/ado-script/src/shared/__tests__/env-facts.test.ts scripts/ado-script/src/shared/env-facts.test.ts renamed to scripts/ado-script/src/shared/__tests__/env-facts.test.ts

@@ -4,7 +4,7 @@ import {
   stripRefPrefix,
   isPipelineVarFact,
   type FactKind,
-} from "./env-facts.js";
+} from "../env-facts.js";
 
 const ALL: { fact: FactKind; env: string }[] = [
   { fact: "pr_title", env: "ADO_PR_TITLE" },

…pts/ado-script/src/shared/policy.test.ts …ript/src/shared/__tests__/policy.test.tsscripts/ado-script/src/shared/policy.test.ts renamed to scripts/ado-script/src/shared/__tests__/policy.test.ts scripts/ado-script/src/shared/policy.test.ts renamed to scripts/ado-script/src/shared/__tests__/policy.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import { PolicyTracker } from "./policy.js";
-import type { FactSpec } from "./types.gen.js";
+import { PolicyTracker } from "../policy.js";
+import type { FactSpec } from "../types.gen.js";
 
 function spec(kind: string, fp: string): FactSpec {
   return { kind, failure_policy: fp };

…ado-script/src/shared/vso-logger.test.ts …/src/shared/__tests__/vso-logger.test.tsscripts/ado-script/src/shared/vso-logger.test.ts renamed to scripts/ado-script/src/shared/__tests__/vso-logger.test.ts scripts/ado-script/src/shared/vso-logger.test.ts renamed to scripts/ado-script/src/shared/__tests__/vso-logger.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import { setOutput, addBuildTag, logWarning, logError, complete } from "./vso-logger.js";
+import { setOutput, addBuildTag, logWarning, logError, complete } from "../vso-logger.js";
 
 describe("vso-logger", () => {
   let writes: string[];

scripts/ado-script/vitest.config.smoke.ts

@@ -0,0 +1,9 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+  test: {
+    // Smoke-test config: targets the bundled gate.js end-to-end. The
+    // suite must run AFTER `npm run build` produces dist/gate/index.js.
+    include: ["test/**/*.test.ts"],
+  },
+});

scripts/ado-script/vitest.config.ts

@@ -0,0 +1,13 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+  test: {
+    // Default suite covers source-side tests under src/. The smoke test
+    // under test/ depends on dist/gate/index.js existing, so it runs via
+    // a separate config — see vitest.config.smoke.ts and
+    // `npm run test:smoke`.
+    include: ["src/**/*.test.ts"],
+  },
+});
+
+