fix: schema path, NodeTool step readability, and glob bracket guard

- Update test_write_schema_to_scripts to write to the canonical
  scripts/ado-script/schema/ path instead of the deleted
  scripts/gate-spec.schema.json location.
- Convert NodeTool@0 step from escaped single-line string to a raw
  string literal, consistent with the adjacent download step.
- Add logWarning guard in globMatch when pattern contains "[" to catch
  compiler/evaluator parity drift early (bracket expressions are treated
  as literals, not character classes).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jamesadevine

scripts/ado-script/src/gate/predicates.ts

@@ -167,11 +167,14 @@ function stringsFromFact(raw: unknown): string[] {
 
 function globMatch(value: string, pattern: string): boolean {
   // Glob → regex: only `*` (any chars) and `?` (single char) are
-  // recognised. Bracket expressions like `[abc]` are escaped to literal
-  // characters here. This is a deliberate divergence from Python's
-  // `fnmatch.fnmatch`, which supports `[seq]` ranges. The IR currently
-  // never emits bracket patterns, but if a future predicate needs them,
-  // this builder must be extended (and the parity inventory updated).
+  // recognised. Bracket expressions like `[abc]` are treated as literals.
+  // The IR currently never emits bracket patterns; warn if one appears so
+  // a compiler/evaluator parity drift is caught early.
+  if (/\[/.test(pattern)) {
+    logWarning(
+      `globMatch: pattern "${pattern}" contains "[" which is treated as a literal, not a character class`,
+    );
+  }
   const escaped = pattern.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
   const regex = `^${escaped.replace(/\\\*/g, ".*").replace(/\\\?/g, ".")}$`;
   return new RegExp(regex, "s").test(value);

src/compile/extensions/trigger_filters.rs

@@ -102,7 +102,12 @@ impl CompilerExtension for TriggerFiltersExtension {
         // acceptable. NodeTool@0 is preinstalled on Microsoft-hosted and 1ES
         // images.
         steps.push(
-            "- task: NodeTool@0\n  inputs:\n    versionSpec: \"20.x\"\n  displayName: \"Install Node.js 20.x for gate evaluator\"\n  condition: succeeded()".to_string(),
+            r#"- task: NodeTool@0
+  inputs:
+    versionSpec: "20.x"
+  displayName: "Install Node.js 20.x for gate evaluator"
+  condition: succeeded()"#
+                .to_string(),
         );
 
         steps.push(format!(

src/compile/filter_ir.rs

@@ -1826,11 +1826,15 @@ mod tests {
     #[test]
     #[ignore] // Writes to source tree — run manually with `cargo test test_write_schema -- --ignored`
     fn test_write_schema_to_scripts() {
-        // Generate schema and write to scripts/ for distribution
+        // Generate schema and write to the canonical location for codegen
         let schema = generate_gate_spec_schema();
         let schema_path = std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR"))
             .join("scripts")
+            .join("ado-script")
+            .join("schema")
             .join("gate-spec.schema.json");
+        std::fs::create_dir_all(schema_path.parent().unwrap())
+            .expect("should create schema dir");
         std::fs::write(&schema_path, &schema).expect("should write schema file");
 
         // Verify it's readable and valid