test: reduce and improve tests in src/compile/ir/ (#1049)

Author: github-actions[bot]

src/compile/ir/condition.rs

@@ -348,7 +348,10 @@ pub mod codegen {
                 "eq(dependencies.Setup.outputs['x.y'], 'true')"
             );
             let c = Condition::Custom("eq(variables['X'], '${{ parameters.y }}')".to_string());
-            assert!(lower_condition(&ctx, &c).is_ok());
+            assert_eq!(
+                lower_condition(&ctx, &c).unwrap(),
+                "eq(variables['X'], '${{ parameters.y }}')"
+            );
         }
 
         #[test]
@@ -403,6 +406,13 @@ mod tests {
     #[test]
     fn not_boxes_inner() {
         let c = Condition::not(Condition::Succeeded);
-        assert!(matches!(c, Condition::Not(_)));
+        if let Condition::Not(inner) = c {
+            assert!(
+                matches!(*inner, Condition::Succeeded),
+                "not() must box the supplied inner condition"
+            );
+        } else {
+            panic!("expected Condition::Not");
+        }
     }
 }

src/compile/ir/ids.rs

@@ -140,11 +140,24 @@ mod tests {
 
     #[test]
     fn distinct_kinds_do_not_share_address_space() {
-        // Compile-time check: a StageId and a JobId with the same inner
-        // string are not interchangeable. This won't even compile if
-        // it isn't true, so the assertion is documentary.
-        let _stage = StageId::new("Foo").unwrap();
-        let _job = JobId::new("Foo").unwrap();
-        // (no assertion needed; the test compiles iff the types are distinct)
+        use std::any::TypeId;
+        // Runtime verification that the three ID newtypes are distinct Rust
+        // types. A coalescing refactor that accidentally unified any two of
+        // them would be caught here.
+        assert_ne!(
+            TypeId::of::<StageId>(),
+            TypeId::of::<JobId>(),
+            "StageId and JobId must be distinct types"
+        );
+        assert_ne!(
+            TypeId::of::<StageId>(),
+            TypeId::of::<StepId>(),
+            "StageId and StepId must be distinct types"
+        );
+        assert_ne!(
+            TypeId::of::<JobId>(),
+            TypeId::of::<StepId>(),
+            "JobId and StepId must be distinct types"
+        );
     }
 }

src/compile/ir/lower.rs

@@ -1958,7 +1958,7 @@ mod tests {
         let g = Graph::default();
         let yaml = serde_yaml::to_string(&lower_with_graph(&p, &g).unwrap()).unwrap();
         assert!(
-            !yaml.contains("name:") || !yaml.contains("should-not-appear"),
+            !yaml.contains("name:"),
             "template shape must not emit top-level `name:`, got: {yaml}"
         );
         assert!(
@@ -2004,7 +2004,7 @@ mod tests {
         let g = Graph::default();
         let yaml = serde_yaml::to_string(&lower_with_graph(&p, &g).unwrap()).unwrap();
         assert!(
-            !yaml.starts_with("name:"),
+            !yaml.contains("name:"),
             "must skip top-level name, got: {yaml}"
         );
         assert!(yaml.contains("jobs:"), "must emit jobs:, got: {yaml}");