style(clippy): fix vec_init_then_push, redundant_static_lifetimes, unused_variable (#734)

Author: github-actions[bot]

src/compile/codemods/mod.rs

@@ -99,7 +99,7 @@ pub struct Codemod {
 /// having run first (e.g. A renames `foo` → `bar`, B operates on
 /// `bar`); idempotency means any codemod can re-run on any source
 /// without harm.
-pub static CODEMODS: &[&'static Codemod] = &[
+pub static CODEMODS: &[&Codemod] = &[
     &m0001_repos_unified::CODEMOD,
     &m0002_pool_object_form::CODEMOD,
 ];

src/compile/common.rs

@@ -6536,7 +6536,7 @@ safe-outputs:
     fn test_generate_awf_mounts_no_extensions() {
         let fm = minimal_front_matter();
         let exts = crate::compile::extensions::collect_extensions(&fm);
-        let ctx = crate::compile::extensions::CompileContext::for_test(&fm);
+        let _ctx = crate::compile::extensions::CompileContext::for_test(&fm);
         let result = generate_awf_mounts(&exts);
         assert_eq!(result, "\\", "no mounts should produce bare continuation");
     }
@@ -6547,7 +6547,7 @@ safe-outputs:
             parse_markdown("---\nname: test\ndescription: test\nruntimes:\n  lean: true\n---\n")
                 .unwrap();
         let exts = crate::compile::extensions::collect_extensions(&fm);
-        let ctx = crate::compile::extensions::CompileContext::for_test(&fm);
+        let _ctx = crate::compile::extensions::CompileContext::for_test(&fm);
         let result = generate_awf_mounts(&exts);
         assert!(result.contains("--mount"), "should contain --mount flag");
         assert!(result.contains(".elan"), "should reference .elan directory");

src/compile/extensions/mod.rs

@@ -677,12 +677,7 @@ extension_enum! {
 /// (runtimes in `RuntimesConfig` field order, tools in `ToolsConfig`
 /// field order).
 pub fn collect_extensions(front_matter: &FrontMatter) -> Vec<Extension> {
-    let mut extensions = Vec::new();
-
     // ── Always-on internal extensions ──
-    extensions.push(Extension::AdoAwMarker(AdoAwMarkerExtension));
-    extensions.push(Extension::GitHub(GitHubExtension));
-    extensions.push(Extension::SafeOutputs(SafeOutputsExtension));
     // Always-on ado-script extension. Owns both the gate evaluator
     // (Setup job) and the runtime-import resolver (Agent job). Internal
     // gating on `filters:` and `inlined-imports` means the extension
@@ -692,11 +687,16 @@ pub fn collect_extensions(front_matter: &FrontMatter) -> Vec<Extension> {
     // resolver step run BEFORE any user-facing Runtime extension (e.g.
     // `NodeExtension`). The user's pinned Node version then "wins last"
     // on PATH for the rest of the Agent job.
-    extensions.push(Extension::AdoScript(AdoScriptExtension {
-        pr_filters: front_matter.pr_filters().cloned(),
-        pipeline_filters: front_matter.pipeline_filters().cloned(),
-        inlined_imports: front_matter.inlined_imports,
-    }));
+    let mut extensions = vec![
+        Extension::AdoAwMarker(AdoAwMarkerExtension),
+        Extension::GitHub(GitHubExtension),
+        Extension::SafeOutputs(SafeOutputsExtension),
+        Extension::AdoScript(AdoScriptExtension {
+            pr_filters: front_matter.pr_filters().cloned(),
+            pipeline_filters: front_matter.pipeline_filters().cloned(),
+            inlined_imports: front_matter.inlined_imports,
+        }),
+    ];
 
     // ── Runtimes (ExtensionPhase::Runtime) ──
     if let Some(lean) = front_matter.runtimes.as_ref().and_then(|r| r.lean.as_ref())