fix(safeoutputs): support glob wildcards anywhere in allowed-tags patterns

tag_matches_pattern only handled a trailing '*' (prefix match). Patterns
like 'copilot:repo=msazuresphere/4x4/*@main' silently fell through to
exact-match comparison, rejecting valid tags such as
'copilot:repo=msazuresphere/4x4/VsCodeExtension@main'.

Switch to glob_match::glob_match (already a dependency) so '*' works in
any position. Also consolidate the inline matching in add_build_tag.rs to
use the shared tag_matches_pattern helper, gaining case-insensitive
matching it was previously missing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jamesadevine

src/safeoutputs/add_build_tag.rs

@@ -161,13 +161,10 @@ impl Executor for AddBuildTagResult {
 
         // 4. Validate against allowed tags (if non-empty)
         if !config.allowed_tags.is_empty() {
-            let allowed = config.allowed_tags.iter().any(|pattern| {
-                if let Some(prefix) = pattern.strip_suffix('*') {
-                    final_tag.starts_with(prefix)
-                } else {
-                    *pattern == final_tag
-                }
-            });
+            let allowed = config
+                .allowed_tags
+                .iter()
+                .any(|pattern| super::tag_matches_pattern(&final_tag, pattern));
             if !allowed {
                 return Ok(ExecutionResult::failure(format!(
                     "Tag '{}' is not in the allowed tags list",

src/safeoutputs/mod.rs

@@ -218,13 +218,13 @@ pub(crate) fn resolve_repo_name(
 ///
 /// Both comparisons are **case-insensitive** so that an operator who writes
 /// `allowed-tags: ["Agent-*"]` correctly matches an agent-provided tag `"agent-created"`.
+///
+/// Supports `*` wildcards anywhere in the pattern (e.g. `copilot:repo=org/project/*@main`).
 pub(crate) fn tag_matches_pattern(tag: &str, pattern: &str) -> bool {
-    if let Some(prefix) = pattern.strip_suffix('*') {
-        tag.to_ascii_lowercase()
-            .starts_with(&prefix.to_ascii_lowercase())
-    } else {
-        pattern.eq_ignore_ascii_case(tag)
-    }
+    glob_match::glob_match(
+        &pattern.to_ascii_lowercase(),
+        &tag.to_ascii_lowercase(),
+    )
 }
 
 /// Validate a string against `git check-ref-format` rules.
@@ -515,4 +515,30 @@ mod tests {
         assert!(tag_matches_pattern("anything", "*"));
         assert!(tag_matches_pattern("", "*"));
     }
+
+    #[test]
+    fn test_tag_matches_pattern_middle_wildcard() {
+        // Glob wildcard in the middle of the pattern
+        assert!(tag_matches_pattern(
+            "copilot:repo=msazuresphere/4x4/VsCodeExtension@main",
+            "copilot:repo=msazuresphere/4x4/*@main"
+        ));
+        assert!(tag_matches_pattern(
+            "copilot:repo=msazuresphere/4x4/DevTools@main",
+            "copilot:repo=msazuresphere/4x4/*@main"
+        ));
+        // Wrong suffix should not match
+        assert!(!tag_matches_pattern(
+            "copilot:repo=msazuresphere/4x4/DevTools@dev",
+            "copilot:repo=msazuresphere/4x4/*@main"
+        ));
+    }
+
+    #[test]
+    fn test_tag_matches_pattern_middle_wildcard_case_insensitive() {
+        assert!(tag_matches_pattern(
+            "Copilot:Repo=MSAzureSphere/4x4/Tools@Main",
+            "copilot:repo=msazuresphere/4x4/*@main"
+        ));
+    }
 }