Skip to content

Commit 74fe82c

Browse files
test: fix incorrect and vacuous tests in create_git_tag and create_issue (#838)
1 parent f38c515 commit 74fe82c

3 files changed

Lines changed: 2 additions & 6 deletions

File tree

src/safeoutputs/create_git_tag.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ mod tests {
422422
}
423423

424424
#[test]
425-
fn test_validation_rejects_empty_tag() {
425+
fn test_validation_rejects_too_short_tag() {
426426
let params = CreateGitTagParams {
427427
tag_name: "ab".to_string(),
428428
commit: None,

src/safeoutputs/create_issue.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -455,11 +455,6 @@ mod tests {
455455
assert_eq!(CreateIssueResult::NAME, "create-issue");
456456
}
457457

458-
#[test]
459-
fn test_result_requires_write() {
460-
const _: () = assert!(CreateIssueResult::REQUIRES_WRITE);
461-
}
462-
463458
#[test]
464459
fn test_validate_rejects_short_title() {
465460
let params = CreateIssueParams {

src/safeoutputs/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -840,6 +840,7 @@ mod tests {
840840
#[test]
841841
fn test_requires_write_consistency() {
842842
// Write-requiring tools
843+
const { assert!(CreateIssueResult::REQUIRES_WRITE); }
843844
const { assert!(CreateWorkItemResult::REQUIRES_WRITE); }
844845
const { assert!(CommentOnWorkItemResult::REQUIRES_WRITE); }
845846
const { assert!(UpdateWorkItemResult::REQUIRES_WRITE); }

0 commit comments

Comments
 (0)