fix: clean up review findings from TypeScript gate evaluator PR

Update stale doc comments referencing Python evaluator to TypeScript.
Fix fnmatch reference in filter-ir.md to describe custom glob semantics.
Hoist toLowerCase() map outside includes() for value_in_set/value_not_in_set
predicates to avoid per-call array allocation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jamesadevine

docs/filter-ir.md

@@ -113,7 +113,7 @@ supports these predicate types:
 
 | Predicate | Bash Shape | Example |
 |-----------|-----------|---------|
-| `GlobMatch { fact, pattern }` | `fnmatch(value, pattern)` | Title matches `*[review]*` |
+| `GlobMatch { fact, pattern }` | Simple glob (`*` any chars, `?` single char) | Title matches `*[review]*` |
 | `Equality { fact, value }` | `[ "$VAR" = "value" ]` | Draft is `false` |
 | `ValueInSet { fact, values, case_insensitive }` | `echo "$VAR" \| grep -q[i]E '^(a\|b)$'` | Author in allow-list |
 | `ValueNotInSet { fact, values, case_insensitive }` | Inverse of `ValueInSet` | Author not in block-list |

scripts/ado-script/src/gate/predicates.ts

@@ -78,15 +78,19 @@ export function evaluatePredicate(p: PredicateSpec, facts: Map<string, unknown>)
       return String(facts.get(p.fact) ?? "") === p.value;
     case "value_in_set": {
       const value = String(facts.get(p.fact) ?? "");
-      return p.case_insensitive
-        ? p.values.map((v) => v.toLowerCase()).includes(value.toLowerCase())
-        : p.values.includes(value);
+      if (p.case_insensitive) {
+        const lower = p.values.map((v) => v.toLowerCase());
+        return lower.includes(value.toLowerCase());
+      }
+      return p.values.includes(value);
     }
     case "value_not_in_set": {
       const value = String(facts.get(p.fact) ?? "");
-      return p.case_insensitive
-        ? !p.values.map((v) => v.toLowerCase()).includes(value.toLowerCase())
-        : !p.values.includes(value);
+      if (p.case_insensitive) {
+        const lower = p.values.map((v) => v.toLowerCase());
+        return !lower.includes(value.toLowerCase());
+      }
+      return !p.values.includes(value);
     }
     case "numeric_range": {
       const value = Number(facts.get(p.fact) ?? 0);

src/compile/extensions/mod.rs

@@ -613,7 +613,7 @@ pub fn collect_extensions(front_matter: &FrontMatter) -> Vec<Extension> {
     }
 
     // ── Trigger filters (ExtensionPhase::Tool) ──
-    // Activated when Tier 2/3 filters require the Python evaluator.
+    // Activated when filters require the gate evaluator (TypeScript gate.js).
     let pr_filters = front_matter.pr_filters().cloned();
     let pipeline_filters = front_matter.pipeline_filters().cloned();
     if TriggerFiltersExtension::is_needed(

src/compile/filter_ir.rs

@@ -919,8 +919,8 @@ pub enum PredicateSpec {
 /// Generate the JSON Schema for the gate spec.
 ///
 /// This schema is the formal contract between the Rust compiler and the
-/// Python evaluator. It should be shipped in `scripts/gate-spec.schema.json`
-/// alongside the evaluator.
+/// TypeScript gate evaluator. It is used to generate `types.gen.ts` in
+/// the `scripts/ado-script` workspace.
 pub fn generate_gate_spec_schema() -> String {
     let schema = schemars::schema_for!(GateSpec);
     serde_json::to_string_pretty(&schema).expect("schema serialization")
@@ -929,13 +929,13 @@ pub fn generate_gate_spec_schema() -> String {
 // ─── Codegen ────────────────────────────────────────────────────────────────
 
 // The inline heredoc evaluator has been removed in favor of external script delivery.
-// See TriggerFiltersExtension for the external path and compile_gate_step_inline for Tier 1.
+// See TriggerFiltersExtension for the external path (bundled TypeScript gate.js).
 
 impl Fact {
     /// ADO macro exports required by this fact.
     ///
-    /// Returns `(env_var_name, ado_macro)` pairs that must be exported in
-    /// the bash shim for the Python evaluator to read.
+    /// Returns `(env_var_name, ado_macro)` pairs that must be set in the
+    /// step's `env:` block for the gate evaluator to read.
     pub fn ado_exports(&self) -> Vec<(&'static str, &'static str)> {
         match self {
             Fact::PrTitle => vec![("ADO_PR_TITLE", "$(System.PullRequest.Title)")],