fix(compile): default non-1es vmImage to ubuntu-22.04 (#578)

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/5e8d9cb1-410b-4f30-92d5-1c4468e92ef6

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>

Author: Copilot

README.md

@@ -238,7 +238,7 @@ the service connections. Approve the permissions and the pipeline is ready.
 | `target` | `standalone` \| `1es` \| `job` \| `stage` | `standalone` | Pipeline output format. `job` and `stage` generate reusable ADO YAML templates rather than complete pipelines. |
 | `engine` | string or object | `copilot` | Engine identifier or object with `id`, `model`, `timeout-minutes`, etc. |
 | `on` | object | — | Unified trigger configuration (`schedule`, `pipeline` completion, `pr` triggers). See [schedule syntax](#schedule-syntax). |
-| `pool` | string or object | `vmImage: ubuntu-latest` (standalone) / `AZS-1ES-L-MMS-ubuntu-22.04` (1ES) | Agent pool |
+| `pool` | string or object | `vmImage: ubuntu-22.04` (standalone) / `AZS-1ES-L-MMS-ubuntu-22.04` (1ES) | Agent pool |
 | `workspace` | `root` \| `repo` \| `self` \| *alias* | auto | Working directory mode. `self` is an alias for `repo`; any checked-out repo alias is also accepted. |
 | `repos` | list | — | Compact repository declarations (replaces legacy `repositories:` + `checkout:`) |
 | `mcp-servers` | map | — | MCP server configuration |

docs/front-matter.md

@@ -18,7 +18,7 @@ engine: copilot # Engine identifier. Defaults to copilot. Currently only 'copilo
 #   timeout-minutes: 30
 workspace: repo # Optional: "root", "repo" (alias: "self"), or a checked-out repository alias. If not specified, defaults to "root" when no additional repositories are listed in `repos:`, and to "repo" when one or more additional repos are checked out. See "Workspace Defaults" below.
 pool:                          # Optional pool configuration
-  vmImage: ubuntu-latest       # Microsoft-hosted (default for non-1ES targets)
+  vmImage: ubuntu-22.04        # Microsoft-hosted (default for non-1ES targets)
 # pool:                        # Self-hosted pool
 #   name: MySelfHostedPool
 # pool:                        # 1ES pool format

docs/targets.md

@@ -42,7 +42,7 @@ The output contains the same 3-job chain (Agent → Detection → SafeOutputs) a
 `standalone`, with:
 - Job names prefixed with the agent name for uniqueness (e.g., `DailyReview_Agent`)
 - No triggers, pipeline name, or resource declarations (the parent pipeline owns those)
-- Pool baked in from the front matter `pool:` field (`vmImage` or `name`; defaults to `vmImage: ubuntu-latest`)
+- Pool baked in from the front matter `pool:` field (`vmImage` or `name`; defaults to `vmImage: ubuntu-22.04`)
 
 Example front matter:
 ```yaml

docs/template-markers.md

@@ -217,7 +217,7 @@ Used by all templates under a `pool:` block and expands to:
 - 1ES target: two lines (`name: <pool>` and `os: <linux|windows>`)
 
 Defaults:
-- non-1ES: `vmImage: ubuntu-latest`
+- non-1ES: `vmImage: ubuntu-22.04`
 - 1ES: `name: AZS-1ES-L-MMS-ubuntu-22.04` + `os: linux`
 
 ## {{ setup_job }}

prompts/create-ado-agentic-workflow.md

@@ -153,7 +153,7 @@ repos:
 
 ### Step 6 — Pool
 
-Default depends on target: standalone uses `vmImage: ubuntu-latest` (Microsoft-hosted); 1ES uses `name: AZS-1ES-L-MMS-ubuntu-22.04`. Only include if overriding the default.
+Default depends on target: standalone uses `vmImage: ubuntu-22.04` (Microsoft-hosted); 1ES uses `name: AZS-1ES-L-MMS-ubuntu-22.04`. Only include if overriding the default.
 
 String form (self-hosted pool by name):
 ```yaml
@@ -163,7 +163,7 @@ pool: MyCustomPool
 Object form (Microsoft-hosted or explicit OS):
 ```yaml
 pool:
-  vmImage: ubuntu-latest   # Microsoft-hosted (standalone default)
+  vmImage: ubuntu-22.04   # Microsoft-hosted (standalone default)
 
 # 1ES pool with explicit OS:
 pool:

src/compile/codemods/0002_pool_object_form.rs

@@ -7,7 +7,7 @@
 //!
 //! When the pool field is **absent** and the compiler version is at or
 //! above `INTRODUCED_IN` (the release that changed the implicit
-//! default from the 1ES self-hosted pool to `vmImage: ubuntu-latest`),
+//! default from the 1ES self-hosted pool to `vmImage: ubuntu-22.04`),
 //! the codemod pins the legacy default explicitly so existing
 //! pipelines are not silently broken.
 
@@ -18,7 +18,7 @@ use super::{Codemod, CodemodContext};
 use crate::compile::common::DEFAULT_ONEES_POOL;
 
 /// Version where the pool default changed from the legacy self-hosted
-/// pool to `vmImage: ubuntu-latest`.
+/// pool to `vmImage: ubuntu-22.04`.
 const INTRODUCED_IN: &str = "0.30.0";
 
 pub static CODEMOD: Codemod = Codemod {
@@ -48,7 +48,7 @@ fn apply_codemod(fm: &mut Mapping, ctx: &CodemodContext) -> Result<bool> {
         // Pool absent — only inject the legacy default for 1ES
         // targets where the old implicit default was the self-hosted
         // pool. Non-1ES (standalone/job/stage) targets now default to
-        // `vmImage: ubuntu-latest`, which is the desired behaviour
+        // `vmImage: ubuntu-22.04`, which is the desired behaviour
         // for new pipelines that omit `pool:`.
         if !version_gte(ctx.compiler_version, INTRODUCED_IN) {
             return Ok(false);
@@ -104,13 +104,13 @@ mod tests {
     #[test]
     fn noops_when_pool_is_already_mapping() {
         let mut fm: Mapping =
-            serde_yaml::from_str("name: x\ndescription: y\npool:\n  vmImage: ubuntu-latest")
+            serde_yaml::from_str("name: x\ndescription: y\npool:\n  vmImage: ubuntu-22.04")
                 .unwrap();
         let changed = apply_codemod(&mut fm, &ctx("0.30.0")).expect("apply");
         assert!(!changed);
         assert_eq!(
             fm.get(Value::String("pool".into())).cloned(),
-            Some(serde_yaml::from_str::<Value>("vmImage: ubuntu-latest").unwrap())
+            Some(serde_yaml::from_str::<Value>("vmImage: ubuntu-22.04").unwrap())
         );
     }
 
@@ -129,7 +129,7 @@ mod tests {
     #[test]
     fn noops_when_pool_absent_standalone_and_version_gte() {
         // Standalone pipelines without pool should get the new
-        // vmImage: ubuntu-latest default, not the legacy 1ES pool.
+        // vmImage: ubuntu-22.04 default, not the legacy 1ES pool.
         let mut fm: Mapping = serde_yaml::from_str("name: x\ndescription: y").unwrap();
         let changed = apply_codemod(&mut fm, &ctx("0.30.0")).expect("apply");
         assert!(!changed);

src/compile/common.rs

@@ -1070,7 +1070,7 @@ pub fn yaml_double_quoted(s: &str) -> String {
 /// Default self-hosted pool for 1ES templates.
 pub const DEFAULT_ONEES_POOL: &str = "AZS-1ES-L-MMS-ubuntu-22.04";
 /// Default Microsoft-hosted VM image for non-1ES templates.
-pub const DEFAULT_VM_IMAGE_POOL: &str = "ubuntu-latest";
+pub const DEFAULT_VM_IMAGE_POOL: &str = "ubuntu-22.04";
 
 /// Resolve the `{{ pool }}` replacement block.
 ///
@@ -7073,7 +7073,7 @@ safe-outputs:
     #[test]
     fn test_resolve_pool_block_non_onees_defaults_to_vm_image() {
         let block = resolve_pool_block(CompileTarget::Standalone, None).expect("pool block");
-        assert_eq!(block, "vmImage: ubuntu-latest");
+        assert_eq!(block, "vmImage: ubuntu-22.04");
     }
 
     #[test]
@@ -7114,7 +7114,7 @@ safe-outputs:
         });
         let block =
             resolve_pool_block(CompileTarget::Standalone, Some(&pool)).expect("pool block");
-        assert_eq!(block, "vmImage: ubuntu-latest");
+        assert_eq!(block, "vmImage: ubuntu-22.04");
     }
 
     #[test]

src/compile/types.rs

@@ -32,7 +32,7 @@ pub enum CompileTarget {
 ///
 /// # Object format (recommended)
 /// pool:
-///   vmImage: ubuntu-latest   # Microsoft-hosted
+///   vmImage: ubuntu-22.04   # Microsoft-hosted
 ///
 /// # Object format (self-hosted)
 /// pool:
@@ -56,7 +56,7 @@ impl Default for PoolConfig {
     fn default() -> Self {
         PoolConfig::Full(PoolConfigFull {
             name: None,
-            vm_image: Some("ubuntu-latest".to_string()),
+            vm_image: Some("ubuntu-22.04".to_string()),
             os: None,
         })
     }
@@ -1357,19 +1357,19 @@ mod tests {
 
     #[test]
     fn test_pool_config_object_vm_image_form() {
-        let yaml = "pool:\n  vmImage: ubuntu-latest";
+        let yaml = "pool:\n  vmImage: ubuntu-22.04";
         let fm: serde_yaml::Value = serde_yaml::from_str(yaml).unwrap();
         let pool: PoolConfig = serde_yaml::from_value(fm["pool"].clone()).unwrap();
         assert_eq!(pool.name(), None);
-        assert_eq!(pool.vm_image(), Some("ubuntu-latest"));
+        assert_eq!(pool.vm_image(), Some("ubuntu-22.04"));
         assert_eq!(pool.os(), "linux");
     }
 
     #[test]
     fn test_pool_config_default_is_vm_image() {
         let pool = PoolConfig::default();
         assert_eq!(pool.name(), None);
-        assert_eq!(pool.vm_image(), Some("ubuntu-latest"));
+        assert_eq!(pool.vm_image(), Some("ubuntu-22.04"));
         assert_eq!(pool.os(), "linux");
     }