Commit c6adf9e
test: remove duplicate PR trigger test in pr_filters (#804)
test_generate_pr_trigger_with_pr_trigger_and_pipeline_trigger was a duplicate
of test_generate_pr_trigger_with_explicit_pr_trigger_overrides_schedule.
Both tests verify the same behavior: when triggers.pr is explicitly set,
generate_pr_trigger returns early at line 499 of src/compile/common.rs,
bypassing the schedule/pipeline suppression logic. The presence of
pipeline: Some(...) vs pipeline: None in the OnConfig setup does not
affect the code path taken, since the function checks has_pipeline_trigger
only after the explicit pr: early return.
The remaining test has been renamed to _overrides_suppression (instead of
_overrides_schedule) and its comments now document that it covers both
the schedule and pipeline suppression cases.
Test count: 32 → 31
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 1f3929b commit c6adf9e
1 file changed
Lines changed: 5 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
127 | 128 | | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
| 129 | + | |
148 | 130 | | |
149 | 131 | | |
150 | 132 | | |
| |||
0 commit comments