feat: add update-work-item safe output

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>

Author: Copilot

src/compile/common.rs

@@ -267,10 +267,7 @@ const DEFAULT_BASH_COMMANDS: &[&str] = &[
 
 /// Generate copilot CLI params from front matter configuration
 pub fn generate_copilot_params(front_matter: &FrontMatter) -> String {
-    let mut allowed_tools: Vec<String> = vec![
-        "github".to_string(),
-        "safeoutputs".to_string(),
-    ];
+    let mut allowed_tools: Vec<String> = vec!["github".to_string(), "safeoutputs".to_string()];
 
     // Edit tool: enabled by default, can be disabled with `edit: false`
     let edit_enabled = front_matter
@@ -515,10 +512,7 @@ pub fn generate_acquire_ado_token(service_connection: Option<&str>, variable_nam
             lines.push("    addSpnToEnvironment: true".to_string());
             lines.push("    inlineScript: |".to_string());
             lines.push("      ADO_TOKEN=$(az account get-access-token \\".to_string());
-            lines.push(format!(
-                "        --resource {} \\",
-                ADO_RESOURCE_ID
-            ));
+            lines.push(format!("        --resource {} \\", ADO_RESOURCE_ID));
             lines.push("        --query accessToken -o tsv)".to_string());
             lines.push(format!(
                 "      echo \"##vso[task.setvariable variable={variable_name};issecret=true]$ADO_TOKEN\""
@@ -534,10 +528,8 @@ pub fn generate_acquire_ado_token(service_connection: Option<&str>, variable_nam
 /// When not configured, omits ADO access tokens entirely.
 pub fn generate_copilot_ado_env(read_service_connection: Option<&str>) -> String {
     match read_service_connection {
-        Some(_) => {
-            "AZURE_DEVOPS_EXT_PAT: $(SC_READ_TOKEN)\nSYSTEM_ACCESSTOKEN: $(SC_READ_TOKEN)"
-                .to_string()
-        }
+        Some(_) => "AZURE_DEVOPS_EXT_PAT: $(SC_READ_TOKEN)\nSYSTEM_ACCESSTOKEN: $(SC_READ_TOKEN)"
+            .to_string(),
         None => String::new(),
     }
 }
@@ -553,7 +545,13 @@ pub fn generate_executor_ado_env(write_service_connection: Option<&str>) -> Stri
 }
 
 /// Safe-output names that require write access to ADO.
-const WRITE_REQUIRING_SAFE_OUTPUTS: &[&str] = &["create-pull-request", "create-work-item", "create-wiki-page", "update-wiki-page"];
+const WRITE_REQUIRING_SAFE_OUTPUTS: &[&str] = &[
+    "create-pull-request",
+    "create-work-item",
+    "update-work-item",
+    "create-wiki-page",
+    "update-wiki-page",
+];
 
 /// Validate that write-requiring safe-outputs have a write service connection configured.
 pub fn validate_write_permissions(front_matter: &FrontMatter) -> Result<()> {
@@ -760,7 +758,10 @@ mod tests {
     #[test]
     fn test_generate_pr_trigger_no_triggers_no_schedule() {
         let result = generate_pr_trigger(&None, false);
-        assert!(result.is_empty(), "Should be empty when no triggers configured");
+        assert!(
+            result.is_empty(),
+            "Should be empty when no triggers configured"
+        );
     }
 
     #[test]
@@ -804,7 +805,10 @@ mod tests {
     #[test]
     fn test_generate_ci_trigger_no_triggers_no_schedule() {
         let result = generate_ci_trigger(&None, false);
-        assert!(result.is_empty(), "Should be empty when no triggers configured");
+        assert!(
+            result.is_empty(),
+            "Should be empty when no triggers configured"
+        );
     }
 
     #[test]

src/execute.rs

@@ -10,8 +10,8 @@ use std::path::Path;
 
 use crate::ndjson::{self, SAFE_OUTPUT_FILENAME};
 use crate::tools::{
-    CreatePrResult, CreateWikiPageResult, CreateWorkItemResult, UpdateWikiPageResult,
-    ExecutionContext, ExecutionResult, Executor,
+    CreatePrResult, CreateWikiPageResult, CreateWorkItemResult, ExecutionContext, ExecutionResult,
+    Executor, UpdateWikiPageResult, UpdateWorkItemConfig, UpdateWorkItemResult,
 };
 
 // Re-export memory types for use by main.rs
@@ -80,6 +80,24 @@ pub async fn execute_safe_outputs(
     info!("Found {} safe output(s) to execute", entries.len());
     println!("Found {} safe output(s) to execute", entries.len());
 
+    // Pre-validate the update-work-item max constraint before executing anything
+    let update_wi_count = entries
+        .iter()
+        .filter(|e| e.get("name").and_then(|n| n.as_str()) == Some("update-work-item"))
+        .count();
+    if update_wi_count > 0 {
+        let update_config: UpdateWorkItemConfig = ctx.get_tool_config("update-work-item");
+        if update_wi_count > update_config.max as usize {
+            return Err(anyhow::anyhow!(
+                "Too many update-work-item safe outputs: {} found, but max is {}. \
+                 Reduce the number of work item updates or increase 'max' in the \
+                 safe-outputs.update-work-item configuration.",
+                update_wi_count,
+                update_config.max
+            ));
+        }
+    }
+
     // Log summary of what we're about to execute
     for (i, entry) in entries.iter().enumerate() {
         if let Some(name) = entry.get("name").and_then(|n| n.as_str()) {
@@ -172,6 +190,13 @@ pub async fn execute_safe_output(
             );
             output.execute_sanitized(ctx).await?
         }
+        "update-work-item" => {
+            debug!("Parsing update-work-item payload");
+            let mut output: UpdateWorkItemResult = serde_json::from_value(entry.clone())
+                .map_err(|e| anyhow::anyhow!("Failed to parse update-work-item: {}", e))?;
+            debug!("update-work-item: id={}", output.id);
+            output.execute_sanitized(ctx).await?
+        }
         "create-pull-request" => {
             debug!("Parsing create-pull-request payload");
             let mut output: CreatePrResult = serde_json::from_value(entry.clone())

src/mcp.rs

@@ -15,6 +15,7 @@ use crate::tools::{
     CreateWorkItemParams, CreateWorkItemResult,
     UpdateWikiPageParams, UpdateWikiPageResult, MissingDataParams, MissingDataResult,
     MissingToolParams, MissingToolResult, NoopParams, NoopResult, ToolResult,
+    UpdateWorkItemParams, UpdateWorkItemResult,
     anyhow_to_mcp_error,
 };
 
@@ -335,6 +336,40 @@ impl SafeOutputs {
         Ok(CallToolResult::success(vec![]))
     }
 
+    #[tool(
+        name = "update-work-item",
+        description = "Update an existing Azure DevOps work item. Only fields explicitly enabled \
+in the pipeline configuration (safe-outputs.update-work-item) may be changed. Updates may be \
+further restricted by target (only a specific work item ID) or title-prefix (only work items \
+whose current title starts with a configured prefix). Provide the work item ID and only the \
+fields you want to update."
+    )]
+    async fn update_work_item(
+        &self,
+        params: Parameters<UpdateWorkItemParams>,
+    ) -> Result<CallToolResult, McpError> {
+        info!("Tool called: update-work-item - id={}", params.0.id);
+        // Sanitize untrusted agent-provided text fields (IS-01)
+        let mut sanitized = params.0;
+        sanitized.title = sanitized.title.map(|t| sanitize_text(&t));
+        sanitized.body = sanitized.body.map(|b| sanitize_text(&b));
+        sanitized.state = sanitized.state.map(|s| sanitize_text(&s));
+        sanitized.work_item_type = sanitized.work_item_type.map(|t| sanitize_text(&t));
+        sanitized.area_path = sanitized.area_path.map(|p| sanitize_text(&p));
+        sanitized.iteration_path = sanitized.iteration_path.map(|p| sanitize_text(&p));
+        sanitized.assignee = sanitized.assignee.map(|a| sanitize_text(&a));
+        sanitized.tags = sanitized
+            .tags
+            .map(|ts| ts.into_iter().map(|t| sanitize_text(&t)).collect());
+        let result: UpdateWorkItemResult = sanitized.try_into()?;
+        let _ = self.write_safe_output_file(&result).await;
+        info!("Work item update queued for #{}", result.id);
+        Ok(CallToolResult::success(vec![Content::text(format!(
+            "Work item #{} update queued. Changes will be applied during safe output processing.",
+            result.id
+        ))]))
+    }
+
     #[tool(
         name = "create-pull-request",
         description = "Create a new pull request to propose code changes. Use this after making file edits to submit them for review and merging. The PR will be created from the current branch with your committed changes. Use 'self' for the pipeline's own repository, or a repository alias from the checkout list."

src/tools/mod.rs

@@ -18,6 +18,7 @@ mod missing_data;
 mod missing_tool;
 mod noop;
 mod result;
+mod update_work_item;
 
 pub use create_pr::*;
 pub use create_wiki_page::*;
@@ -29,3 +30,4 @@ pub use noop::*;
 pub use result::{
     ExecutionContext, ExecutionResult, Executor, ToolResult, Validate, anyhow_to_mcp_error,
 };
+pub use update_work_item::*;