fix: wire engine.max-turns and engine.timeout-minutes into copilot CLI params#132
Closed
Copilot wants to merge 2 commits into
Closed
fix: wire engine.max-turns and engine.timeout-minutes into copilot CLI params#132Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/93f28d3d-00e2-43fe-b409-2eee78756e2b Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix silent ignores for max-turns and timeout-minutes
fix: wire engine.max-turns and engine.timeout-minutes into copilot CLI params
Apr 7, 2026
Collaborator
|
Yeah this isn't right |
Collaborator
|
Closing - max-turns is a Claude code feature. Timeout in minutes could be mapped through to generated yaml, but not required at this time. Copilot CLI does have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EngineOptions.max_turnsandEngineOptions.timeout_minuteswere parsed from front matter but never referenced ingenerate_copilot_params, silently dropping user-configured values.Changes
src/compile/common.rs: After emitting--model, conditionally emit--max-turns <N>and--timeout-minutes <N>when set in the engine configGenerates:
Both flags are optional and only emitted when explicitly set; simple string engine format (
engine: claude-opus-4.5) is unaffected.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.github.com (HTTP Only)/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow api.github.com /lib64/ld-linux-x86-64.so.2 -pie 3nf9mf3llfipq39tfpe.0elucli.rcgu.o 0cmbw9s1epj6u5lpg56.0elucli.rcgu.o 7ns8xajcyieow2pqerb.0elucli.rcgu.o eqqftmr5yjelvmaemg2.0elucli.rcgu.o 26d0v3d6wijxp99vrzb.0elucli.rcgu.o 007cw4wrggmhyy9p9wp.0elucli.rcgu.o 37rz1yw28luopeai196.0elucli.rcgu.o hz87sxryo6wpxkg0j9n.0elucli.rcgu.o kt4eq9l93halxbc4t0n.0elucli.rcgu.o ggd6dihfhwgwakedav9.0elucli.rcgu.o v6ffhd8jays209wgj5n.0elucli.rcgu.o egyf2bjavduout6f0k2.0elucli.rcgu.o niuk96o2ye0nwmzljby.0elucli.rcgu.o vj2war7u5lefjl8opjn.0elucli.rcgu.o(packet block)dev.azure.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-ec3615b173f842cf /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-ec3615b173f842cf embed-bitcode=no -C debuginfo=2 --test --check-cfg 2regaihc7r5d18zliln5ku8z.0rj9ojm.rcgu.o bo8h4r0ac505s02ct9e9jfja.0rj9ojm.rcgu.o hn3pk8m2qs5yvgvz2lhp494g.0rj9ojm.rcgu.o imo2xsvhz31piwzuu8maj71s.0rj9ojm.rcgu.o jb6ukj1d9vltv4tvdb2aptbe.0rj9ojm.rcgu.o k6bus1woc864lk0ypulsh3ye.0rj9ojm.rcgu.o tbuk6o45y9vvg5cz9ct0lzry.0rj9ojm.rcgu.o uqvlm05fjogoxbv0012u6xvl.0rj9ojm.rcgu.o azmhriamtr91bvha3pxyqnz5.0rj9ojm.rcgu.o clcp8wiv2dn2tyge8zo6sya2.0rj9ojm.rcgu.o dtuuubbi1poec8h30b6t4tp8.0rj9ojm.rcgu.o kowmyjxwwcclh6toq1dlrf6o.0rj9ojm.rcgu.o lltr8u89xait5bf8u1j3czre.0rj9ojm.rcgu.o pdyehqhj2fm71ur0cn11ungu.0rj9ojm.rcgu.o(dns block)/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow api.github.com --allow dev.azure.com --allow *.visualstudio.com 7ns8xajcyieow2pqerb.0elucli.rcgu.o eqqftmr5yjelvmaemg2.0elucli.rcgu.o 26d0v3d6wijxp99vrzb.0elucli.rcgu.o 007cw4wrggmhyy9p9wp.0elucli.rcgu.o 37rz1yw28luopeai196.0elucli.rcgu.o hz87sxryo6wpxkg0j9n.0elucli.rcgu.o kt4eq9l93halxbc4t0n.0elucli.rcgu.o ggd6dihfhwgwakedav9.0elucli.rcgu.o v6ffhd8jays209wgj5n.0elucli.rcgu.o egyf2bjavduout6f0k2.0elucli.rcgu.o niuk96o2ye0nwmzljby.0elucli.rcgu.o vj2war7u5lefjl8opjn.0elucli.rcgu.o(dns block)github.github.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)msazuresphere.visualstudio.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow api.github.com --allow dev.azure.com --allow *.visualstudio.com 7ns8xajcyieow2pqerb.0elucli.rcgu.o eqqftmr5yjelvmaemg2.0elucli.rcgu.o 26d0v3d6wijxp99vrzb.0elucli.rcgu.o 007cw4wrggmhyy9p9wp.0elucli.rcgu.o 37rz1yw28luopeai196.0elucli.rcgu.o hz87sxryo6wpxkg0j9n.0elucli.rcgu.o kt4eq9l93halxbc4t0n.0elucli.rcgu.o ggd6dihfhwgwakedav9.0elucli.rcgu.o v6ffhd8jays209wgj5n.0elucli.rcgu.o egyf2bjavduout6f0k2.0elucli.rcgu.o niuk96o2ye0nwmzljby.0elucli.rcgu.o vj2war7u5lefjl8opjn.0elucli.rcgu.o(dns block)raw.github.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow *.github.com /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-d7b205d2f6ee756b.1gkg93gwdysjiryikxtmf5b5x.10dmqdn.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-d7b205d2f6ee756b.1nybvizmkcj78n5jmgma2zoto.10dmqdn.rcgu.o 3nf9mf3llfipq39tfpe.0elucli.rcgu.o 0cmbw9s1epj6u5lpg56.0elucli.rcgu.o 7ns8xajcyieow2pqerb.0elucli.rcgu.o eqqftmr5yjelvmaemg2.0elucli.rcgu.o 26d0v3d6wijxp99vrzb.0elucli.rcgu.o 007cw4wrggmhyy9p9wp.0elucli.rcgu.o 37rz1yw28luopeai196.0elucli.rcgu.o hz87sxryo6wpxkg0j9n.0elucli.rcgu.o kt4eq9l93halxbc4t0n.0elucli.rcgu.o ggd6dihfhwgwakedav9.0elucli.rcgu.o v6ffhd8jays209wgj5n.0elucli.rcgu.o egyf2bjavduout6f0k2.0elucli.rcgu.o niuk96o2ye0nwmzljby.0elucli.rcgu.o vj2war7u5lefjl8opjn.0elucli.rcgu.o(dns block)If you need me to access, download, or install something from one of these locations, you can either: