fix(executor-e2e): invoke .js test fixture via process.execPath on Windows#1616
Merged
Conversation
…ndows Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
July 21, 2026 16:20
View session
jamesadevine
marked this pull request as ready for review
July 21, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows has no OS-level shebang support, so
spawn('fake-ado-aw.js', args)fires a childerrorevent (ENOENT/ENOEXEC).runner.tscatches the rejection and returns{ ok: false }, causing"passes an expected executor rejection without running assertions"to fail withExpected result.ok=true, received false.Summary
In
execute-cli.ts(test-harness only, not shipped inado-script.zip), resolve.jsbinaries throughprocess.execPathon Windows before callingspawnCollect:The production
ado-awbinary is always a native executable — never.js— so the Windows branch is only exercised by test fixtures.Test plan
npx vitest run src/executor-e2e/__tests__/runner.test.ts— 3/3 passnpm test— 565/565 passnpm run typecheck— clean