Skip to content

fix(executor-e2e): invoke .js test fixture via process.execPath on Windows #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 1 commit into from
Jul 21, 2026
Merged

fix(executor-e2e): invoke .js test fixture via process.execPath on Windows #1616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scripts/ado-script/src/executor-e2e/execute-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,18 @@ export async function runExecute(opts: RunExecuteOptions): Promise<RunExecuteRes
...opts.extraEnv,
};

// On Windows, a .js file cannot be spawned directly (no OS-level shebang
// support). When the configured binary is a Node script, invoke it through
// the current Node executable instead so both Linux and Windows work
// identically. The real ado-aw binary is always a native executable and is
// never a .js file, so this branch is only exercised by test fixtures.
const [spawnCmd, spawnArgs] =
process.platform === "win32" && opts.adoAwBin.endsWith(".js")
? [process.execPath, [opts.adoAwBin, ...args]]
: [opts.adoAwBin, args];

opts.log(`[${opts.tool}] running: ${opts.adoAwBin} ${args.join(" ")}`);
const { exitCode, stdout, stderr } = await spawnCollect(opts.adoAwBin, args, env);
const { exitCode, stdout, stderr } = await spawnCollect(spawnCmd, spawnArgs, env);
if (stdout.trim()) opts.log(`[${opts.tool}] stdout:\n${stdout.trim()}`);
if (stderr.trim()) opts.log(`[${opts.tool}] stderr:\n${stderr.trim()}`);

Expand Down
Loading