Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/safe_outputs/link_work_items.rs
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,11 @@ mod tests {
link_type: "related".to_string(),
comment: None,
};
let result: Result<LinkWorkItemsResult, _> = params.try_into();
assert!(result.is_err());
let err = LinkWorkItemsResult::try_from(params).unwrap_err();
assert!(
err.to_string().contains("source_id must be positive"),
"expected error about source_id, got: {err}"
);
}

#[test]
Expand All @@ -352,8 +355,11 @@ mod tests {
link_type: "related".to_string(),
comment: None,
};
let result: Result<LinkWorkItemsResult, _> = params.try_into();
assert!(result.is_err());
let err = LinkWorkItemsResult::try_from(params).unwrap_err();
assert!(
err.to_string().contains("target_id must be positive"),
"expected error about target_id, got: {err}"
);
}

#[test]
Expand All @@ -364,8 +370,11 @@ mod tests {
link_type: "related".to_string(),
comment: None,
};
let result: Result<LinkWorkItemsResult, _> = params.try_into();
assert!(result.is_err());
let err = LinkWorkItemsResult::try_from(params).unwrap_err();
assert!(
err.to_string().contains("source_id and target_id must be different"),
"expected error about same ids, got: {err}"
);
}

#[test]
Expand All @@ -376,8 +385,11 @@ mod tests {
link_type: "unknown".to_string(),
comment: None,
};
let result: Result<LinkWorkItemsResult, _> = params.try_into();
assert!(result.is_err());
let err = LinkWorkItemsResult::try_from(params).unwrap_err();
assert!(
err.to_string().contains("invalid link_type"),
"expected error about invalid link_type, got: {err}"
);
}

#[test]
Expand Down
8 changes: 6 additions & 2 deletions src/safe_outputs/missing_tool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@ mod tests {
#[test]
fn test_params_requires_tool_name() {
let json = r#"{"context": "why"}"#;
let result: Result<MissingToolParams, _> = serde_json::from_str(json);
assert!(result.is_err());
let result = serde_json::from_str::<MissingToolParams>(json);
let err = result.map(|_| ()).unwrap_err().to_string();
assert!(
err.contains("tool_name"),
"expected error about missing tool_name field, got: {err}"
);
}

#[tokio::test]
Expand Down
Loading