refactor: reduce complexity of build_conclusion_job in agentic_pipeline.rs

[github-actions]

What was complex

build_conclusion_job in src/compile/agentic_pipeline.rs contained a 65-line loop body that applied per-tool conclusion env vars for noop, missing-tool, and missing-data. The body had 5–6 levels of nesting:

for tool_key          ← level 1
  if let Some(cfg)    ← level 2
    if cfg.is_bool()  ← level 3
      if == Some(false) ← level 4
    if let Some(obj)  ← level 3
      if let Some(v)  ← level 4
        if let Some(s) ← level 5  (report-as-work-item)

The string-field fan-out (title-prefix, work-item-type, area-path, iteration-path) was repeated verbatim five times.

What changed

Two private helpers extracted:

apply_tool_config_envs(step, env_prefix, obj) -> BashStep

Handles the object-form config for one tool. String fields are driven by a data-table slice so adding a new config key requires one entry, not a new if let block.

apply_conclusion_tool_config(step, tool_key, tool_config) -> BashStep

Handles the bool/object dispatch for one tool: derives env_prefix, handles the false-bool early-return, then delegates to apply_tool_config_envs.

The per-tool loop in build_conclusion_job becomes:

for tool_key in &["noop", "missing-tool", "missing-data"] {
    if let Some(tool_config) = front_matter.safe_outputs.get(*tool_key) {
        conclusion_step = apply_conclusion_tool_config(conclusion_step, tool_key, tool_config);
    }
}

Verification

• All tests pass (cargo test)
• Clippy is clean (cargo clippy --all-targets --all-features)
• No behaviour change: the same env vars are set with the same values in the same order

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Cyclomatic Complexity Reducer · 90.1 AIC · ⌖ 12.7 AIC · ⊞ 7.2K · ◷