Skip to content

refactor: migrate CreatePrResult to use tool_result! macro#197

Merged
jamesadevine merged 2 commits into
mainfrom
refactor/create-pr-tool-result-macro
Apr 14, 2026
Merged

refactor: migrate CreatePrResult to use tool_result! macro#197
jamesadevine merged 2 commits into
mainfrom
refactor/create-pr-tool-result-macro

Conversation

@jamesadevine

Copy link
Copy Markdown
Collaborator

Closes #158.

Changes

  • Added CreatePrResultFields params struct to satisfy the macro's TryFrom generation
  • Kept manual Sanitize and Executor implementations unchanged

Testing

All tests pass. No functional changes — pure refactor.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

…conflicts

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>

Copilot AI commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in commit 40e1587. The only conflict was in src/safeoutputs/create_pr.rs — I merged in the agent_labels and base_commit fields from main by adding them to both CreatePrResultFields and the tool_result! macro invocation. All tests pass.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dev.azure.com
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-9e77bcf2d2e71c5c /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-9e77bcf2d2e71c5c --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 s8bh6bqv41s2319di46asrf.0d4c108.rcgu.o 4zmymm5xy858jt27kthnfh9.0d4c108.rcgu.o f405hqo0gjtxdqv8zehrqnh.0d4c108.rcgu.o jl45usujjublhf4m77hr5mo.0d4c108.rcgu.o admplelk8e2ksj15ay7gg05.0d4c108.rcgu.o gkyurq8x77swisnglb5grq4.0d4c108.rcgu.o kkmxb8z3wp24qxw612o70dw.0d4c108.rcgu.o 6fv98y05j3dbhy4hh13kfsq.0d4c108.rcgu.o b2b4jxojxchv4j1ps3y4sfe.0d4c108.rcgu.o fgqw5x57tysy244o93l1kuz.0d4c108.rcgu.o 8dvobo85nsp5ss8kazc5m2i.0d4c108.rcgu.o zeoeqgil90rlr6ni72d27wq.0d4c108.rcgu.o 1gb29y45pp0f3iewur23wvv.0d4c108.rcgu.o mqpk7kamquqfa9vpoyffrrx.0d4c108.rcgu.o (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@jamesadevine jamesadevine merged commit a5ac136 into main Apr 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: migrate CreatePrResult to use tool_result! macro

2 participants