Skip to content

chore: remove proxy subcommand#198

Merged
jamesadevine merged 1 commit into
mainfrom
chore/remove-proxy-subcommand
Apr 14, 2026
Merged

chore: remove proxy subcommand#198
jamesadevine merged 1 commit into
mainfrom
chore/remove-proxy-subcommand

Conversation

@jamesadevine

Copy link
Copy Markdown
Collaborator

Closes #195.

Changes

Removes the proxy subcommand entirely — it's no longer needed since MCPG handles network routing.

  • Deleted src/proxy.rs (417 lines)
  • Removed Commands::Proxy variant and handler from src/main.rs
  • Deleted tests/proxy_tests.rs (488 lines)
  • Removed proxy references from README.md and AGENTS.md

Testing

All remaining tests pass. No code depends on the proxy module.

The proxy subcommand is obsolete now that MCPG handles network routing.

- Delete src/proxy.rs and tests/proxy_tests.rs
- Remove Commands::Proxy variant and match arm from main.rs
- Remove mod proxy declaration and unused log::debug import
- Remove proxy CLI docs from README.md and AGENTS.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine jamesadevine merged commit 8087f15 into main Apr 14, 2026
4 checks passed
@jamesadevine jamesadevine deleted the chore/remove-proxy-subcommand branch April 14, 2026 20:35
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Rust PR Review

Summary: Needs changes — the 1ES template still calls the deleted proxy subcommand, which will cause runtime failures for all 1ES pipelines.

Findings

🐛 Bugs / Logic Issues

  • templates/1es-base.yml:214 — The "Start network proxy" step still calls $AGENTIC_PIPELINES_PATH proxy, which is the subcommand this PR deletes. Any pipeline compiled with target: 1es will fail at this step with a "unknown command: proxy" error. Lines 215–260 (PID tracking, port capture, proxy env vars for HTTPS_PROXY, "Stop network proxy" teardown step) are all dead weight that should be cleaned up too.

    This is the only blocking issue, but it's a complete breakage for the 1es target.

⚠️ Suggestions

  • src/allowed_hosts.rs:6 — Module doc still says "The network proxy (runtime HTTP filtering, used by AnalyzeSafeOutputs in legacy mode)". Stale reference; worth trimming.

  • src/compile/mod.rs:6 — Module doc says "Full-featured pipeline with custom network proxy, MCP firewall...". The proxy framing is now inaccurate.

✅ What Looks Good

  • Clean deletion: src/proxy.rs (417 lines) and tests/proxy_tests.rs (488 lines) removed without leaving dangling mod declarations or dead imports.
  • use log::debug import correctly removed alongside the one callsite that used it.
  • All 716+ existing tests pass cleanly.
  • README.md and AGENTS.md docs updated correctly.

Generated by Rust PR Reviewer for issue #198 · ● 632.7K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proxy: remove

1 participant