Skip to content

fix: stale doc comment and unescaped service connection name #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesadevine wants to merge 1 commit into from
Closed

fix: stale doc comment and unescaped service connection name #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/compile/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ pub fn replace_with_indent(template: &str, placeholder: &str, replacement: &str)
result
}

/// Generate a schedule YAML block from a ScheduleConfig.
/// When no explicit schedule branches are configured, defaults to `main`.
/// Generate the top-level `parameters:` YAML block from front matter parameters.
///
/// Returns a YAML block like:
Expand Down Expand Up @@ -898,7 +896,7 @@ pub fn generate_acquire_ado_token(service_connection: Option<&str>, variable_nam
r#" displayName: "Acquire ADO token ({variable_name})""#
));
lines.push(" inputs:".to_string());
lines.push(format!(" azureSubscription: '{}'", sc));
lines.push(format!(" azureSubscription: '{}'", sc.replace('\'', "''")));
lines.push(" scriptType: 'bash'".to_string());
lines.push(" scriptLocation: 'inlineScript'".to_string());
lines.push(" addSpnToEnvironment: true".to_string());
Expand Down
Loading