Skip to content

chore(workflows): remove bot triggers from agentic workflows#344

Merged
jamesadevine merged 1 commit into
mainfrom
copilot/remove-bot-triggers-agentic-workflows
Apr 28, 2026
Merged

chore(workflows): remove bot triggers from agentic workflows#344
jamesadevine merged 1 commit into
mainfrom
copilot/remove-bot-triggers-agentic-workflows

Conversation

Copilot AI commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Drops the bots: ["copilot[bot]"] trigger from rust-pr-reviewer, scout-command, issue-plan-maker, and rust-review-command, then recompiles all agentic workflows.

  • Source .md edits: removed the bots: block under on: in the four workflows above.
  • Recompile: ran gh aw compile; all 9 workflow lock files regenerated (0 errors, 0 warnings). The unrelated lock-file churn is from the locally installed gh aw version refreshing pinned actions/manifests.

Test plan

gh aw compile — 9/9 workflows compiled cleanly.

@jamesadevine

Copy link
Copy Markdown
Collaborator

/rust-review

@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Rust PR Reviewer completed successfully!

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Rust PR Review

Summary: No Rust source changes — this PR only modifies workflow .md definitions and their compiled .lock.yml files. The intent (removing bots: triggers) is correct, but there are concerns about the recompile.

Findings

🔒 Security Concerns

  • All recompiled .lock.yml files — The gh-aw-actions/setup action is now referenced as github/gh-aw-actions/setup@v0.68.1 (a mutable tag), replacing the previous @ba90f2186d7ad780ec640f364005fa24e797b360 # v0.68.3 (immutable SHA). Tags can be force-pushed to point to arbitrary commits. This is a supply chain security regression affecting all 9 recompiled workflows. The previous SHA-pinned reference was the secure form.

⚠️ Suggestions

  • Scope / version churn — The PR description acknowledges that 5 unrelated workflows (cyclomatic-complexity-reducer, doc-freshness-check, red-team-security, test-gap-finder, update-awf-version) got recompiled with the locally-installed compiler v0.68.1, downgrading them from v0.68.3. This rolls back those workflows from AWF v0.25.20v0.25.18 and from upload-artifact@v7.0.1v7. Ideally the recompile would use the same compiler version that last generated those files, or at minimum the changes to unrelated workflows should be reviewed as a separate concern.

  • issue-plan-maker.lock.yml — The activation.if condition was simplified correctly when bots: was removed (the extra conjunctive || (!(github.event_name == 'issues')) && (!(github.event_name == 'issue_comment')) clause is gone). This looks intentional and correct.

✅ What Looks Good

  • The four targeted .md source edits are minimal and correct — only the bots: block is removed, no other front matter is touched.
  • The compiled lock files correctly no longer include the # bots: / # - copilot[bot] commented-out trigger lines.
  • No Rust source files were touched; no correctness or safety issues in the compiler itself.

Generated by Rust PR Reviewer for issue #344 · ● 595.1K ·

@jamesadevine jamesadevine merged commit e156c8f into main Apr 28, 2026
@jamesadevine jamesadevine deleted the copilot/remove-bot-triggers-agentic-workflows branch April 28, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants