fix(workflows): allow github CDN egress in recompile-safe-output-fixtures#864
Merged
Merged
Conversation
…ures GitHub release downloads redirect to release-assets.githubusercontent.com, which is covered by the `github` ecosystem identifier but not by `defaults`. Without it, AWF blocks the curl in Step 2 and the workflow loops through its 12 retry attempts then aborts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
githubecosystem identifier tonetwork.allowedin therecompile-safe-output-fixturesworkflow.The workflow's Step 2 downloads
ado-aw-linux-x64andchecksums.txtfrom a GitHub Release. Those URLs return a 302 redirect torelease-assets.githubusercontent.com, which is not covered by thedefaultsecosystem — it's covered bygithub(per gh-aw network reference).Without the
githubecosystem listed, AWF blocks the redirected CDN host and the agent silently loops through all 12 retry attempts (~6 minutes) before aborting — observed on run 27019604536.Change
This is the only workflow in the repo that performs direct asset downloads via
curlfrom a GitHub Release (the others useghAPI calls, which already work). So no other workflow needs the same change.Test plan
gh aw compile recompile-safe-output-fixturesregenerated the lock file cleanly.workflow_dispatchagainst tagv0.31.1and confirm Step 2 succeeds without retry loop, Step 3 produces a non-empty diff (currenttests/safe-outputs/*.lock.ymlfiles are stamped with an older compiler version), and the PR is opened with the expected title.