fix(workflows): add integrity heuristic and per-file compile loop to recompile-safe-output-fixtures#868
Merged
jamesadevine merged 1 commit intoJun 5, 2026
Conversation
…recompile-safe-output-fixtures The previous iteration of the workflow silently no-op'd on release v0.31.1 because `ado-aw compile tests/safe-outputs/` exits 0 with "0 compiled, N skipped" when given a directory argument (issue #867). It also did not catch the case where the on-disk lock files were stamped by a non-release build, which is what triggered the manual recompile in the first place. This change: - Replaces `ado-aw compile tests/safe-outputs/` with a per-file loop `for md in tests/safe-outputs/*.md; do ado-aw compile --force "$md"; done` run from the repo root. `--force` is required to bypass the GitHub-remote guard inside this repo. - Adds Step 2.5 (pre-flight `ado-aw check`) to detect drift between the released binary and the committed lock files independent of any version string comparison. - Adds Step 3.5 (post-compile sanity) that re-runs `ado-aw check` against every recompiled lock file and hard-fails with `report-incomplete` if any still report drift. - Updates the no-op decision logic so the agent only emits `noop` when both the git diff is empty AND pre-flight integrity passed for every file. An empty diff plus failed integrity now emits `report-incomplete`. - Updates the PR body and "When NOT to open a PR" guidance to reference the new integrity signals. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
deleted the
fix/recompile-fixtures-integrity-and-per-file-compile
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in the
recompile-safe-output-fixturesagentic workflow that surfaced on the v0.31.1 run (run 27020309715):Silent no-op on directory argument. The compile step ran
ado-aw compile tests/safe-outputs/, which exits 0 with0 compiled, N skippedbecausecompileonly accepts a single.mdfile or no args (autodiscovery). The agent then correctly saw "no diff" and emittednoop, masking the fact that nothing was actually compiled. Replaced with a per-filefor md in tests/safe-outputs/*.md; do ado-aw compile --force "$md"; doneloop run from the repo root. Tracked as a separate compiler bug in compile: directory argument silently no-ops instead of auto-discovering or erroring #867.Missing drift detection. The previous version relied solely on
git statusafter recompile. If the on-disk lock files were stamped by a non-releaseado-awbuild (which is what triggered the manual recompile in the first place), the agent could conclude "already up to date" against the wrong baseline. Added two integrity checkpoints:ado-aw checkagainst every lock file before recompile and records the count of files that fail integrity.ado-aw checkagainst every recompiled lock file and hard-fails withreport-incompleteif any still fail.nooponly when the git diff is empty AND pre-flight integrity passed for every file. An empty diff plus failed integrity now emitsreport-incompleteso the failure is visible.Test plan
tests/safe-outputs/*.mdto confirm it walks all 26 fixtures.ado-aw check <lock.yml>exit codes against modified vs unmodified fixtures.gh aw compile recompile-safe-output-fixturesagainst the localgh awinstall.Related: #867 (the compiler bug that allows the directory argument to silently no-op).