fix(workflows): broaden allowed-files glob to cover flat tests/safe-outputs layout#871
Merged
Merged
Conversation
…utputs layout The previous allowed-files entry only matched tests/safe-outputs/<dir>/*.lock.yml (the ** wildcard requires at least one intermediate directory), so the flat tests/safe-outputs/<name>.lock.yml fixtures were rejected by the create_pull_request safe-output policy. Add the flat glob alongside the recursive one so both layouts are covered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the safe-output policy failure observed when the agent tried to open the recompile PR:
The previous
allowed-filesentry wastests/safe-outputs/**/*.lock.yml. The**segment in gh-aw's glob matcher requires at least one intermediate directory level, so it only coveredtests/safe-outputs/<dir>/*.lock.yml. The actual fixtures live flat attests/safe-outputs/<name>.lock.yml, so every recompiled file was rejected and the PR creation failed.This adds the flat glob alongside the recursive one:
The recursive glob is kept so the policy still works if a future test fixture is moved into a subdirectory.
Test plan
tests/safe-outputs/*.lock.yml.gh aw compile recompile-safe-output-fixtures.Follows from #868 and #869.