Skip to content

Commit 86cab46

Browse files
committed
updates for stronger linting
1 parent 1f181b3 commit 86cab46

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

workflows/daily-perf-improver.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ To decide which phase to perform:
101101

102102
1. Check for open PR titled "${{ github.workflow }} - Updates to complete configuration". If exists then comment "configuration needs completion" and exit.
103103

104-
2. Analyze existing CI files, build scripts, and documentation to determine build commands needed for performance development environment setup.
104+
2. Analyze existing CI files, build scripts, and documentation to determine build commands needed for performance development, testing tools (if any used in repo), linting tools (if any used in repo), code formatting tools (if any used in repo) and other environment setup.
105105

106106
3. Create `.github/actions/daily-perf-improver/build-steps/action.yml` with validated build steps. Each step must log output to `build-steps.log` in repo root. Cross-check against existing CI/devcontainer configs.
107107

@@ -151,11 +151,13 @@ To decide which phase to perform:
151151

152152
d. Measure performance impact. Document measurement attempts even if unsuccessful. If no improvement then iterate, revert, or try different approach.
153153

154-
e. Apply any automatic code formatting used in the repo
154+
3. **Finalizing changes**
155155

156-
f. Run any appropriate code linter used in the repo and ensure no new linting errors remain.
156+
a. Apply any automatic code formatting used in the repo.
157157

158-
3. **Results and learnings**
158+
b. Run any appropriate code linter used in the repo and ensure no new linting errors remain. Check the CI checks to see what linting is being used.
159+
160+
4. **Results and learnings**
159161

160162
a. If you succeeded in writing useful code changes that improve performance, create a draft pull request with your changes.
161163

@@ -180,5 +182,5 @@ To decide which phase to perform:
180182

181183
b. If failed or lessons learned then add more files to the PR branch to update relevant performance guide in `.github/copilot/instructions/` with insights. Create a new guide if needed, or split, merge or delete existing guides as appropriate. This is your chance to improve the performance engineering documentation for next time, so you and your team don't make the same mistakes again! Make the most of it!
182184

183-
4. **Final update**: Add brief comment (1 or 2 sentences) to the discussion identified at the start of the workflow stating goal worked on, PR links, and progress made.
185+
5. **Final update**: Add brief comment (1 or 2 sentences) to the discussion identified at the start of the workflow stating goal worked on, PR links, and progress made.
184186

0 commit comments

Comments
 (0)