[Autoloop: python-to-go-migration] Iteration 43: migrate policy/helptext, policy/outcomerouting, primitives/primparser, output/scriptformatters

Run: https://github.com/githubnext/apm/actions/runs/25865196805

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: github-actions[bot]

benchmarks/migration-status.json

@@ -0,0 +1,143 @@
+// Package scriptformatters provides ASCII-only CLI output formatters for
+// APM script execution.
+// Migrated from src/apm_cli/output/script_formatters.py.
+// Rich/colour output is omitted -- all output is plain ASCII.
+package scriptformatters
+
+import (
+	"fmt"
+	"strings"
+)
+
+// ScriptExecutionFormatter formats script execution output as plain ASCII lines.
+type ScriptExecutionFormatter struct{}
+
+// NewScriptExecutionFormatter returns a new formatter.
+func NewScriptExecutionFormatter() *ScriptExecutionFormatter {
+	return &ScriptExecutionFormatter{}
+}
+
+// FormatScriptHeader formats the script execution header with parameters.
+func (f *ScriptExecutionFormatter) FormatScriptHeader(scriptName string, params map[string]string) []string {
+	lines := []string{fmt.Sprintf("[>] Running script: %s", scriptName)}
+	for k, v := range params {
+		lines = append(lines, fmt.Sprintf("  - %s: %s", k, v))
+	}
+	return lines
+}
+
+// FormatCompilationProgress formats prompt compilation progress.
+func (f *ScriptExecutionFormatter) FormatCompilationProgress(promptFiles []string) []string {
+	if len(promptFiles) == 0 {
+		return nil
+	}
+	var lines []string
+	if len(promptFiles) == 1 {
+		lines = append(lines, "Compiling prompt...")
+	} else {
+		lines = append(lines, fmt.Sprintf("Compiling %d prompts...", len(promptFiles)))
+	}
+	for _, pf := range promptFiles {
+		lines = append(lines, fmt.Sprintf("|- %s", pf))
+	}
+	if len(lines) > 1 {
+		lines[len(lines)-1] = strings.Replace(lines[len(lines)-1], "|-", "+-", 1)
+	}
+	return lines
+}
+
+// FormatRuntimeExecution formats runtime command execution details.
+func (f *ScriptExecutionFormatter) FormatRuntimeExecution(runtime, command string, contentLength int) []string {
+	return []string{
+		fmt.Sprintf("Executing %s runtime...", runtime),
+		fmt.Sprintf("|- Command: %s", command),
+		fmt.Sprintf("+- Prompt content: %d characters", contentLength),
+	}
+}
+
+// FormatContentPreview formats a content preview (plain text, no rich boxes).
+func (f *ScriptExecutionFormatter) FormatContentPreview(content string, maxPreview int) []string {
+	if maxPreview <= 0 {
+		maxPreview = 200
+	}
+	preview := content
+	if len(content) > maxPreview {
+		preview = content[:maxPreview] + "..."
+	}
+	return []string{
+		"Prompt preview:",
+		strings.Repeat("-", 50),
+		preview,
+		strings.Repeat("-", 50),
+	}
+}
+
+// FormatEnvironmentSetup formats environment setup information.
+func (f *ScriptExecutionFormatter) FormatEnvironmentSetup(runtime string, envVarsSet []string) []string {
+	if len(envVarsSet) == 0 {
+		return nil
+	}
+	lines := []string{"Environment setup:"}
+	for _, v := range envVarsSet {
+		lines = append(lines, fmt.Sprintf("|- %s: configured", v))
+	}
+	if len(lines) > 1 {
+		lines[len(lines)-1] = strings.Replace(lines[len(lines)-1], "|-", "+-", 1)
+	}
+	return lines
+}
+
+// FormatExecutionSuccess formats a successful execution result.
+// executionTime < 0 means not provided.
+func (f *ScriptExecutionFormatter) FormatExecutionSuccess(runtime string, executionTime float64) []string {
+	msg := fmt.Sprintf("[+] %s execution completed successfully", titleCase(runtime))
+	if executionTime >= 0 {
+		msg += fmt.Sprintf(" (%.2fs)", executionTime)
+	}
+	return []string{msg}
+}
+
+// FormatExecutionError formats an execution error result.
+func (f *ScriptExecutionFormatter) FormatExecutionError(runtime string, errorCode int, errorMsg string) []string {
+	lines := []string{
+		fmt.Sprintf("x %s execution failed (exit code: %d)", titleCase(runtime), errorCode),
+	}
+	if errorMsg != "" {
+		for _, line := range strings.Split(errorMsg, "\n") {
+			if strings.TrimSpace(line) != "" {
+				lines = append(lines, "  "+line)
+			}
+		}
+	}
+	return lines
+}
+
+// FormatSubprocessDetails formats subprocess execution details.
+func (f *ScriptExecutionFormatter) FormatSubprocessDetails(args []string, contentLength int) []string {
+	quoted := make([]string, len(args))
+	for i, a := range args {
+		if strings.Contains(a, " ") {
+			quoted[i] = `"` + a + `"`
+		} else {
+			quoted[i] = a
+		}
+	}
+	return []string{
+		"Subprocess execution:",
+		fmt.Sprintf("|- Args: %s", strings.Join(quoted, " ")),
+		fmt.Sprintf("+- Content: +%d chars appended", contentLength),
+	}
+}
+
+// FormatAutoDiscoveryMessage formats the message for auto-discovered prompts.
+func (f *ScriptExecutionFormatter) FormatAutoDiscoveryMessage(scriptName, promptFile, runtime string) string {
+	return fmt.Sprintf("[i] Auto-discovered: %s (runtime: %s)", promptFile, runtime)
+}
+
+// titleCase capitalises the first rune of s.
+func titleCase(s string) string {
+	if s == "" {
+		return s
+	}
+	return strings.ToUpper(s[:1]) + s[1:]
+}

internal/output/scriptformatters/scriptformatters.go

@@ -0,0 +1,9 @@
+// Package helptext contains shared help text for policy-related CLI commands.
+// Migrated from src/apm_cli/policy/_help_text.py.
+package helptext
+
+// PolicySourceFormsHelp is the canonical user-facing description of the
+// --policy / --policy-source argument formats accepted by discover_policy.
+const PolicySourceFormsHelp = "Accepts: 'org' (auto-discover from your project's git remote), " +
+	"'owner/repo' (defaults to github.com), an https:// URL, or a " +
+	"local file path."

internal/policy/helptext/helptext.go

@@ -0,0 +1,189 @@
+// Package outcomerouting is the single source of truth for the 9-outcome
+// policy-discovery routing table.
+// Migrated from src/apm_cli/policy/outcome_routing.py.
+package outcomerouting
+
+import (
+	"fmt"
+
+	"github.com/githubnext/apm/internal/policy/schema"
+)
+
+// PolicyViolationError is raised when a policy demands fail-closed behaviour.
+type PolicyViolationError struct {
+	Message      string
+	PolicySource string
+}
+
+func (e *PolicyViolationError) Error() string {
+	return e.Message
+}
+
+// PolicyFetchResult holds the result of a discover_policy call.
+type PolicyFetchResult struct {
+	Outcome         string
+	Source          string
+	Cached          bool
+	Error           string
+	FetchError      string
+	CacheAgeSeconds int
+	Policy          *schema.ApmPolicy
+}
+
+// PolicyLogger is the minimal interface expected of a logger for routing.
+type PolicyLogger interface {
+	PolicyResolved(source string, cached bool, enforcement string, ageSeconds int)
+	PolicyDiscoveryMiss(outcome string, source string, err string)
+}
+
+// outcomesHonoringFetchFailureDefault is the set of outcomes that respect the
+// project-side policy.fetch_failure_default knob.
+var outcomesHonoringFetchFailureDefault = map[string]bool{
+	"malformed":           true,
+	"cache_miss_fetch_fail": true,
+	"garbage_response":    true,
+	"no_git_remote":       true,
+	"absent":              true,
+	"empty":               true,
+}
+
+// nonFoundLoggedOutcomes is the set of outcomes routed through the canonical
+// policy_discovery_miss logger helper.
+var nonFoundLoggedOutcomes = map[string]bool{
+	"absent":              true,
+	"no_git_remote":       true,
+	"empty":               true,
+	"malformed":           true,
+	"cache_miss_fetch_fail": true,
+	"garbage_response":    true,
+}
+
+// RouteDiscoveryOutcome routes a PolicyFetchResult to logging and fail-closed
+// decisions.
+//
+// Parameters:
+//   - fetchResult: result of discover_policy_with_chain
+//   - logger: logger implementing PolicyLogger (nil is tolerated)
+//   - fetchFailureDefault: project-side policy.fetch_failure_default ("warn" or "block")
+//   - raiseBlockingErrors: when true, return a PolicyViolationError for blocking outcomes
+//
+// Returns the effective ApmPolicy when enforcement should proceed, nil otherwise.
+// When raiseBlockingErrors is true and a blocking condition is met, a non-nil error
+// is returned alongside a nil policy.
+func RouteDiscoveryOutcome(
+	fetchResult PolicyFetchResult,
+	logger PolicyLogger,
+	fetchFailureDefault string,
+	raiseBlockingErrors bool,
+) (*schema.ApmPolicy, error) {
+	outcome := fetchResult.Outcome
+	source := fetchResult.Source
+
+	if outcome == "disabled" {
+		return nil, nil
+	}
+
+	// hash_mismatch: ALWAYS fail closed regardless of fetch_failure_default.
+	if outcome == "hash_mismatch" {
+		errStr := fetchResult.Error
+		if errStr == "" {
+			errStr = fetchResult.FetchError
+		}
+		if logger != nil {
+			logger.PolicyDiscoveryMiss("hash_mismatch", source, errStr)
+		}
+		if raiseBlockingErrors {
+			return nil, &PolicyViolationError{
+				Message: fmt.Sprintf(
+					"Install blocked: policy hash mismatch -- pinned policy.hash "+
+						"does not match fetched policy bytes (source=%s). "+
+						"Update apm.yml policy.hash or contact your org admin.",
+					sourceOrUnknown(source),
+				),
+				PolicySource: sourceOrUnknown(source),
+			}
+		}
+		return nil, nil
+	}
+
+	// 6 of 9 non-found outcomes route through the canonical logger helper.
+	if nonFoundLoggedOutcomes[outcome] {
+		errStr := fetchResult.Error
+		if errStr == "" {
+			errStr = fetchResult.FetchError
+		}
+		if logger != nil {
+			logger.PolicyDiscoveryMiss(outcome, source, errStr)
+		}
+		if raiseBlockingErrors &&
+			outcomesHonoringFetchFailureDefault[outcome] &&
+			fetchFailureDefault == "block" {
+			return nil, &PolicyViolationError{
+				Message: fmt.Sprintf(
+					"Install blocked: no enforceable org policy was resolved "+
+						"(outcome=%s) and project apm.yml has "+
+						"policy.fetch_failure_default=block (source=%s)",
+					outcome,
+					sourceOrUnknown(source),
+				),
+				PolicySource: sourceOrUnknown(source),
+			}
+		}
+		return nil, nil
+	}
+
+	// cached_stale: log, enforce with the cached policy, potentially fail closed.
+	if outcome == "cached_stale" {
+		policy := fetchResult.Policy
+		if logger != nil {
+			if policy != nil {
+				enforcement := policy.Enforcement
+				if enforcement == "" {
+					enforcement = "warn"
+				}
+				logger.PolicyResolved(source, true, enforcement, fetchResult.CacheAgeSeconds)
+			}
+			logger.PolicyDiscoveryMiss("cached_stale", source, fetchResult.FetchError)
+		}
+		if raiseBlockingErrors && policy != nil {
+			ff := policy.FetchFailure
+			if ff == "" {
+				ff = "warn"
+			}
+			if ff == "block" {
+				return nil, &PolicyViolationError{
+					Message: fmt.Sprintf(
+						"Install blocked: org policy refresh failed and the cached "+
+							"policy declares fetch_failure=block (source=%s)",
+						sourceOrUnknown(source),
+					),
+					PolicySource: sourceOrUnknown(source),
+				}
+			}
+		}
+		return policy, nil
+	}
+
+	// found: normal path
+	if outcome == "found" {
+		policy := fetchResult.Policy
+		if logger != nil && policy != nil {
+			enforcement := policy.Enforcement
+			if enforcement == "" {
+				enforcement = "warn"
+			}
+			logger.PolicyResolved(source, fetchResult.Cached, enforcement, fetchResult.CacheAgeSeconds)
+		}
+		return policy, nil
+	}
+
+	// Defensive: unrecognised outcome -- skip enforcement.
+	return nil, nil
+}
+
+func sourceOrUnknown(s string) string {
+	if s == "" {
+		return "unknown"
+	}
+	return s
+}

internal/policy/outcomerouting/outcomerouting.go

@@ -54,6 +54,8 @@ Cache       PolicyCache
 Deps        DependencyPolicy
 MCP         McpPolicy
 Compilation CompilationPolicy
+Enforcement  string // warn | block | off (default: warn)
+FetchFailure string // warn | block (default: warn)
 }
 
 // DefaultDependencyPolicy returns a DependencyPolicy with sensible defaults.

internal/policy/schema/schema.go

@@ -1,6 +1,11 @@
 // Package primmodels defines data models for APM primitives.
 package primmodels
 
+// Primitive is the common interface for all APM primitive types.
+type Primitive interface {
+	Validate() []string
+}
+
 // Chatmode represents a chatmode primitive.
 type Chatmode struct {
 Name        string
@@ -60,6 +65,14 @@ Version     string
 Source      string
 }
 
+// Validate returns validation errors for a Context.
+func (c *Context) Validate() []string {
+if c.Content == "" {
+return []string{"Empty content"}
+}
+return nil
+}
+
 // Skill represents a skill primitive.
 type Skill struct {
 Name        string
@@ -72,6 +85,11 @@ Version     string
 Source      string
 }
 
+// Validate returns validation errors for a Skill.
+func (s *Skill) Validate() []string {
+return nil
+}
+
 // Agent represents an agent primitive.
 type Agent struct {
 Name        string