[Crane: crane-migration-python-to-go-full-apm-cli-rewrite] Iteration 146: fix errcli.go wrong quote transform + mcp install probe handling

Root cause analysis of PYTHON_CLI_CONTRACT_STATUS=1:

1. errcli.go incorrectly transformed 'Error: No such option: --X'
   into 'Error: No such option '--X'.' (adding single quotes and a
   trailing period). Python Click 8.2.1 outputs no quotes, no period:
   just 'Error: No such option: --X'. Remove the transformation block.

2. runMCPInstall skipped dash-prefixed args as name, producing
   'Error: Missing argument NAME.' (1 line) for the probe arg.
   Python Click with ignore_unknown_options=True assigns
   --definitely-not-an-apm-option to the NAME positional, then
   forwards to 'apm install' which rejects it with a 4-line error
   rooted in the install context. Mirror by: accepting dash-prefixed
   args as name, then emitting install-context unknown-option error
   so errcli.go produces the correct 4-line output.

Actions run: https://github.com/githubnext/apm/actions/runs/28269459014

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: github-actions[bot]

cmd/apm/cmd_mcp.go

@@ -83,16 +83,26 @@ func runMCPInstall(args []string) int {
 		case "--limit":
 			i++ // skip value
 		default:
-			// Mirror Python Click: args starting with '-' are unknown options
-			// (they go to ctx.args via ignore_unknown_options=True and never
-			// fill the NAME positional). Only non-dash args are positional.
-			if !startsWith(a, "--limit=") && !startsWith(a, "-") && name == "" {
+			// Mirror Python Click ignore_unknown_options=True: any non-flag arg
+			// (including dash-prefixed) is accepted as NAME positional, just as
+			// Click assigns it to ctx.args and then to the NAME argument.
+			if !startsWith(a, "--limit=") && name == "" {
 				name = a
 			}
 		}
 	}
 	if name == "" {
 		fmt.Fprintln(os.Stderr, "Error: Missing argument 'NAME'.")
+		fmt.Fprintln(os.Stderr, "Try 'apm mcp install --help' for help.")
+		return 2
+	}
+	// Python forwards: cli.main(["install", "--mcp", name, ...], standalone_mode=False)
+	// When name starts with '-', apm install rejects it as an unknown option.
+	// Mirror that: emit the install-context unknown-option error so errcli.go
+	// produces the same 4-line format Python Click generates.
+	if startsWith(name, "-") {
+		fmt.Fprintf(os.Stderr, "Error: No such option: %s\n", name)
+		fmt.Fprintln(os.Stderr, "Try 'apm install --help' for help.")
 		return 2
 	}
 

cmd/apm/errcli.go

@@ -83,13 +83,9 @@ func (w *clickErrWriter) processLine(line string) {
 			tryContent := strings.TrimPrefix(line, "Try '")
 			tryContent = strings.TrimSuffix(strings.TrimRight(tryContent, "\n"), "' for help.")
 			cmdPath := strings.TrimSuffix(tryContent, " --help")
-			// Convert Go "Error: No such option: --X" to Click 8.x "Error: No such option '--X'."
+			// Pass through the error line unchanged -- Python Click 8.x uses
+			// "Error: No such option: --X" (colon, no quotes, no period).
 			errLine := w.pending
-			const errPrefix = "Error: No such option: "
-			if strings.HasPrefix(errLine, errPrefix) {
-				opt := strings.TrimRight(strings.TrimPrefix(errLine, errPrefix), "\n")
-				errLine = "Error: No such option '" + opt + "'.\n"
-			}
 			fmt.Fprintf(w.w, "%s\n%s\n%s", usageLine(cmdPath), line, errLine)
 			w.pending = ""
 			return