Merge origin/main: resolve score.go conflict, bring in workflow-disabled renames and plan.md

Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>

Author: Copilot

.crane/migrations/crane-migration-python-to-go-full-apm-cli-rewrite/plan.md

@@ -0,0 +1,42 @@
+# Migration Plan: APM CLI Python to Go
+
+## Strategy: Greenfield
+
+The Go implementation is built in parallel alongside the existing Python codebase.
+The Python version stays runnable for benchmark parity testing throughout.
+End state is a clean Go binary with no Python in the shipping artifact.
+
+## Milestones
+
+| # | Milestone | Scope | Acceptance | Status |
+|---|-----------|-------|------------|--------|
+| 0 | Planning | Inventory, plan, scoring scaffold | Plan committed, score.go exists | done |
+| 1 | Build scaffolding | go.mod, go.sum, cmd/apm/main.go stub, CI | `go build ./...` passes, CI green | todo |
+| 2 | Go test/parity harness | acceptance tests calling Python binary, parity framework | score.go returns valid JSON, parity_total >= 10 | todo |
+| 3 | utils/ + constants + config | internal/utils, internal/constants, internal/config | parity tests pass for all util functions | todo |
+| 4 | models/ + primitives/ | internal/models, internal/primitives | parity tests pass for data structures | todo |
+| 5 | deps/ | internal/deps -- dependency resolution | parity tests pass for dep resolution | todo |
+| 6 | cache/ | internal/cache -- HTTP/git caching | parity tests pass for cache layer | todo |
+| 7 | core/ | internal/core -- auth, target detection, orchestration | parity tests pass for core | todo |
+| 8 | install/ | internal/install -- install pipeline and phases | parity tests pass for install | todo |
+| 9 | commands/ | internal/commands -- cobra replacing click | all commands respond correctly | todo |
+| 10 | integration/ | internal/integration -- file integrators | parity tests pass for integrators | todo |
+| 11 | compilation/ | internal/compilation -- compilation pipeline | parity tests pass for compilation | todo |
+| 12 | runtime/ | internal/runtime -- runtime adapters | parity tests pass | todo |
+| 13 | policy/ + security/ | internal/policy, internal/security | parity tests pass | todo |
+| 14 | marketplace/ + registry/ | internal/marketplace, internal/registry | parity tests pass | todo |
+| 15 | bundle/ + output/ | internal/bundle, internal/output | parity tests pass | todo |
+| 16 | CLI entry point wiring | cmd/apm/ final wiring | full CLI parity, migration_score = 1.0 | todo |
+
+## Source Inventory Summary
+
+- **302 Python files** across 20 modules
+- Largest modules: install (49), commands (44), marketplace (28), deps (25), utils (20)
+- Key external Python deps: click, rich, requests, pyyaml, gitpython, ruamel.yaml, watchdog
+
+## Notes
+
+- Never modify src/apm_cli/ (Python source) -- it is the parity reference
+- Never modify tests/ -- Python test suite is the parity oracle
+- The score.go script must not be modified after milestone 1 is accepted
+- Target: migration_score = 1.0 (all parity tests passing, all Go tests passing)

.crane/scripts/score.go

@@ -1,11 +1,14 @@
 //go:build ignore
 
-// score.go: Crane migration scoring script.
-// Usage: cd cmd/apm && go test -json ./... | go run ../../.crane/scripts/score.go
+// score.go -- migration scoring script for the APM CLI Python-to-Go migration.
+// Usage: go test -json ./... | go run .crane/scripts/score.go
+// Outputs JSON with migration_score and progress metrics.
 //
-// Reads go test JSON output from stdin and emits a migration score JSON object.
-// migration_score = (parity_passing / parity_total) * correctness_gate
-// where correctness_gate = 1.0 if all target tests pass, 0.0 otherwise.
+// Scoring formula:
+//   migration_score = (parity_passing / parity_total) * correctness_gate
+//   correctness_gate = 1.0 if all target tests pass, 0.0 otherwise
+//
+// NOTE: This script must NOT be modified after milestone 1 is accepted.
 
 package main
 
@@ -14,17 +17,17 @@ import (
 	"encoding/json"
 	"fmt"
 	"os"
+	"strings"
 )
 
 type TestEvent struct {
-	Action  string  `json:"Action"`
-	Test    string  `json:"Test"`
-	Package string  `json:"Package"`
-	Elapsed float64 `json:"Elapsed"`
-	Output  string  `json:"Output"`
+	Action  string `json:"Action"`
+	Package string `json:"Package"`
+	Test    string `json:"Test"`
+	Output  string `json:"Output"`
 }
 
-type ScoreOutput struct {
+type Score struct {
 	MigrationScore     float64 `json:"migration_score"`
 	Progress           float64 `json:"progress"`
 	ParityPassing      int     `json:"parity_passing"`
@@ -35,68 +38,69 @@ type ScoreOutput struct {
 }
 
 func main() {
-	var passed, failed int
 	scanner := bufio.NewScanner(os.Stdin)
 
+	var parityPassing, parityTotal, targetPassing, targetTotal int
+
 	for scanner.Scan() {
-		line := scanner.Bytes()
-		if len(line) == 0 {
+		line := scanner.Text()
+		if !strings.HasPrefix(line, "{") {
 			continue
 		}
 		var ev TestEvent
-		if err := json.Unmarshal(line, &ev); err != nil {
+		if err := json.Unmarshal([]byte(line), &ev); err != nil {
 			continue
 		}
 		if ev.Test == "" {
-			// package-level event
 			continue
 		}
-		switch ev.Action {
-		case "pass":
-			passed++
-		case "fail":
-			failed++
+
+		isParity := strings.Contains(ev.Test, "Parity") || strings.Contains(ev.Package, "parity")
+		isTarget := strings.HasPrefix(ev.Package, "github.com/githubnext/apm/")
+
+		if isParity {
+			if ev.Action == "run" {
+				parityTotal++
+			} else if ev.Action == "pass" {
+				parityPassing++
+			}
+		}
+		if isTarget {
+			if ev.Action == "run" {
+				targetTotal++
+			} else if ev.Action == "pass" {
+				targetPassing++
+			}
 		}
 	}
 
-	total := passed + failed
-	// parity_total is the number of Python source modules (302).
-	// Until parity tests are wired, this reflects Go test count.
-	const parityTotal = 302
-	parityPassing := 0
-	if total > 0 {
-		parityPassing = passed
+	correctnessGate := 1.0
+	if targetTotal > 0 && targetPassing < targetTotal {
+		correctnessGate = 0.0
 	}
 
-	correctnessGate := 0.0
-	if total > 0 && failed == 0 {
-		correctnessGate = 1.0
-	} else if total == 0 {
-		// No tests yet -- score is 0 but not a failure.
-		correctnessGate = 0.0
+	total := 302 // fixed: total Python modules/functions to port
+	if parityTotal > total {
+		total = parityTotal
 	}
 
-	progress := 0.0
-	if parityTotal > 0 {
-		progress = float64(parityPassing) / float64(parityTotal)
+	var migrationScore float64
+	if total > 0 {
+		migrationScore = (float64(parityPassing) / float64(total)) * correctnessGate
 	}
 
-	migrationScore := progress * correctnessGate
+	progress := float64(parityPassing) / float64(total)
 
-	out := ScoreOutput{
+	score := Score{
 		MigrationScore:     migrationScore,
 		Progress:           progress,
 		ParityPassing:      parityPassing,
-		ParityTotal:        parityTotal,
-		SourceTestsPassing: 247,
-		TargetTestsPassing: passed,
+		ParityTotal:        total,
+		SourceTestsPassing: 247, // stable Python baseline
+		TargetTestsPassing: targetPassing,
 		PerfRatio:          1.0,
 	}
 
-	enc := json.NewEncoder(os.Stdout)
-	enc.SetIndent("", "  ")
-	if err := enc.Encode(out); err != nil {
-		fmt.Fprintf(os.Stderr, "score.go: encode error: %v\n", err)
-		os.Exit(1)
-	}
+	out, _ := json.MarshalIndent(score, "", "  ")
+	fmt.Println(string(out))
 }